Skip to content

Commit d9dbc4a

SuGliderpre-commit-ci-lite[bot]

and

pre-commit-ci-lite[bot]

authored

fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() (#11070)

* fix(matter): itshall set digital mode before digitalWrite * fix(matter): example must set pin in digital mode before writting * fix(matter): example shall set digital mode before writing * fix(matter): digitalMode necessary before digitalWrite(LOW) * fix(matter): example must set digital mode after analogwrite * fix(matter): wrong copy paste * ci(pre-commit): Apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

1 parent e680e7b commit d9dbc4aCopy full SHA for d9dbc4a

File tree

5 files changed

+20

-0

lines changed

libraries/Matter/examples
- MatterColorLight
  - MatterColorLight.ino
- MatterDimmableLight
  - MatterDimmableLight.ino
- MatterEnhancedColorLight
  - MatterEnhancedColorLight.ino
- MatterFan
  - MatterFan.ino
- MatterTemperatureLight
  - MatterTemperatureLight.ino

5 files changed

+20

-0

lines changed

`‎libraries/Matter/examples/MatterColorLight/MatterColorLight.ino‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,10 @@ bool setLightState(bool state, espHsvColor_t colorHSV) {`
`60`	`60`	`analogWrite(ledPin, colorHSV.v);`
`61`	`61`	`#endif`
`62`	`62`	`} else {`
	`63`	`+#ifndef RGB_BUILTIN`
	`64`	`+ // after analogWrite(), it is necessary to set the GPIO to digital mode first`
	`65`	`+ pinMode(ledPin, OUTPUT);`
	`66`	`+#endif`
`63`	`67`	`digitalWrite(ledPin, LOW);`
`64`	`68`	`}`
`65`	`69`	`// store last HSV Color and OnOff state for when the Light is restarted / power goes off`

`‎libraries/Matter/examples/MatterDimmableLight/MatterDimmableLight.ino‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@ bool setLightState(bool state, uint8_t brightness) {`
`56`	`56`	`analogWrite(ledPin, brightness);`
`57`	`57`	`#endif`
`58`	`58`	`} else {`
	`59`	`+#ifndef RGB_BUILTIN`
	`60`	`+ // after analogWrite(), it is necessary to set the GPIO to digital mode first`
	`61`	`+ pinMode(ledPin, OUTPUT);`
	`62`	`+#endif`
`59`	`63`	`digitalWrite(ledPin, LOW);`
`60`	`64`	`}`
`61`	`65`	`// store last Brightness and OnOff state for when the Light is restarted / power goes off`

`‎libraries/Matter/examples/MatterEnhancedColorLight/MatterEnhancedColorLight.ino‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,10 @@ bool setLightState(bool state, espHsvColor_t colorHSV, uint8_t brighteness, uint`
`64`	`64`	`analogWrite(ledPin, colorHSV.v);`
`65`	`65`	`#endif`
`66`	`66`	`} else {`
	`67`	`+#ifndef RGB_BUILTIN`
	`68`	`+ // after analogWrite(), it is necessary to set the GPIO to digital mode first`
	`69`	`+ pinMode(ledPin, OUTPUT);`
	`70`	`+#endif`
`67`	`71`	`digitalWrite(ledPin, LOW);`
`68`	`72`	`}`
`69`	`73`	`// store last HSV Color and OnOff state for when the Light is restarted / power goes off`

`‎libraries/Matter/examples/MatterFan/MatterFan.ino‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,10 @@ void fanDCMotorDrive(bool fanState, uint8_t speedPercent) {`
`49`	`49`	`// drive the Fan DC motor`
`50`	`50`	`if (fanState == false) {`
`51`	`51`	`// turn off the Fan`
	`52`	`+#ifndef RGB_BUILTIN`
	`53`	`+ // after analogWrite(), it is necessary to set the GPIO to digital mode first`
	`54`	`+ pinMode(dcMotorPin, OUTPUT);`
	`55`	`+#endif`
`52`	`56`	`digitalWrite(dcMotorPin, LOW);`
`53`	`57`	`} else {`
`54`	`58`	`// set the Fan speed`

`‎libraries/Matter/examples/MatterTemperatureLight/MatterTemperatureLight.ino‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,10 @@ bool setLightState(bool state, uint8_t brightness, uint16_t temperature_Mireds)`
`66`	`66`	`analogWrite(ledPin, brightness);`
`67`	`67`	`#endif`
`68`	`68`	`} else {`
	`69`	`+#ifndef RGB_BUILTIN`
	`70`	`+ // after analogWrite(), it is necessary to set the GPIO to digital mode first`
	`71`	`+ pinMode(ledPin, OUTPUT);`
	`72`	`+#endif`
`69`	`73`	`digitalWrite(ledPin, LOW);`
`70`	`74`	`}`
`71`	`75`	`// store last Brightness and OnOff state for when the Light is restarted / power goes off`

0 commit comments

Comments

(0)