Commit ab23e8a

authored

Greatly reduces error rate (half, or 0 zero errors, depends on in/out ranges) for round-trip mapping at the same performance. (#3655)

(Based on "improved_map" from ESP8266's Servo.cpp)

1 parent 5999b7b commit ab23e8aCopy full SHA for ab23e8a

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,11 +66,11 @@ long random(long howsmall, long howbig)`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`long map(long x, long in_min, long in_max, long out_min, long out_max) {`
`69`		`- long divisor = (in_max - in_min);`
`70`		`- if(divisor == 0){`
`71`		`- return -1; //AVR returns -1, SAM returns 0`
`72`		`- }`
`73`		`- return (x - in_min) * (out_max - out_min) / divisor + out_min;`
	`69`	`+ constlong dividend = out_max - out_min;`
	`70`	`+ constlongdivisor = in_max - in_min;`
	`71`	`+ constlong delta = x - in_min;`
	`72`	`+`
	`73`	`+ return (delta * dividend + (divisor / 2)) / divisor + out_min;`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`unsigned int makeWord(unsigned int w)`

Comments

(0)