Commit e96fe6c

committed

Adding select_related and prefetch_for_includes to CommentViewSet

1 parent 5a7d73a commit e96fe6cCopy full SHA for e96fe6c

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,9 @@ def test_query_count_include_author(self):`
`48`	`48`
`49`	`49`	`1. Primary resource COUNT query`
`50`	`50`	`2. Primary resource SELECT`
`51`		`- 3. Author's prefetched`
	`51`	`+ 3. Authors prefetched`
	`52`	`+ 3. Entries prefetched`
`52`	`53`	`"""`
`53`		`- with self.assertNumQueries(3):`
	`54`	`+ with self.assertNumQueries(4):`
`54`	`55`	`response = self.client.get('/comments?include=author&page_size=25')`
`55`	`56`	`self.assertEqual(len(response.data['results']), 25)`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,13 @@ class AuthorViewSet(ModelViewSet):`
`73`	`73`
`74`	`74`
`75`	`75`	`class CommentViewSet(ModelViewSet):`
`76`		`- queryset = Comment.objects.all()`
	`76`	`+ queryset = Comment.objects.select_related('author', 'entry')`
`77`	`77`	`serializer_class = CommentSerializer`
	`78`	`+ prefetch_for_includes = {`
	`79`	`+ '__all__': [],`
	`80`	`+ 'author': ['author', 'author__bio', 'author__entries'],`
	`81`	`+ 'entry': ['author', 'author__bio', 'author__entries']`
	`82`	`+ }`
`78`	`83`
`79`	`84`
`80`	`85`	`class CompanyViewset(ModelViewSet):`

Comments

(0)