Commit d1163ce

authored

Ensured that no fields are returned when sparse fields is set to an empty value (#1240)

1 parent 53469f3 commit d1163ceCopy full SHA for d1163ce

File tree

+16

-2

lines changed

+16

-2

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ any parts of the framework not mentioned in the documentation should generally b`
`13`	`13`	`### Fixed`
`14`	`14`
`15`	`15`	`* Re-enabled overwriting of url field (regression since 7.0.0)`
	`16`	`+* Ensured that no fields are rendered when sparse fields is set to an empty value. (regression since 7.0.0)`
`16`	`17`
`17`	`18`	`## [7.0.1] - 2024年06月06日`
`18`	`19`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,7 @@ def _filter_sparse_fields(cls, serializer, fields, resource_name):`
`439`	`439`	`sparse_fieldset_value = request.query_params.get(`
`440`	`440`	`sparse_fieldset_query_param`
`441`	`441`	`)`
`442`		`- if sparse_fieldset_value:`
	`442`	`+ if sparse_fieldset_valueisnotNone:`
`443`	`443`	`sparse_fields = sparse_fieldset_value.split(",")`
`444`	`444`	`return {`
`445`	`445`	`field_name: field`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ def _readable_fields(self):`
`89`	`89`	`sparse_fieldset_value = request.query_params.get(`
`90`	`90`	`sparse_fieldset_query_param`
`91`	`91`	`)`
`92`		`- if sparse_fieldset_value:`
	`92`	`+ if sparse_fieldset_valueisnotNone:`
`93`	`93`	`sparse_fields = sparse_fieldset_value.split(",")`
`94`	`94`	`return (`
`95`	`95`	`field`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -219,6 +219,19 @@ def test_list_allow_overwiritng_url_with_sparse_fields(self, client, url_instanc`
`219`	`219`	`}`
`220`	`220`	`]`
`221`	`221`
	`222`	`+ @pytest.mark.urls(__name__)`
	`223`	`+ def test_list_with_sparse_fields_empty_value(self, client, model):`
	`224`	`+ url = reverse("basic-model-list")`
	`225`	`+ response = client.get(url, data={"fields[BasicModel]": ""})`
	`226`	`+ assert response.status_code == status.HTTP_200_OK`
	`227`	`+ data = response.json()["data"]`
	`228`	`+ assert data == [`
	`229`	`+ {`
	`230`	`+ "type": "BasicModel",`
	`231`	`+ "id": str(model.pk),`
	`232`	`+ }`
	`233`	`+ ]`
	`234`	`+`
`222`	`235`	`@pytest.mark.urls(__name__)`
`223`	`236`	`def test_retrieve(self, client, model):`
`224`	`237`	`url = reverse("basic-model-detail", kwargs={"pk": model.pk})`

Comments

(0)