Commit a6644eb

authored

Align overwriting of get_queryset in example app and documentation (#979)

Fixes #487

1 parent f8209c0 commit a6644ebCopy full SHA for a6644eb

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -620,14 +620,14 @@ class LineItemViewSet(viewsets.ModelViewSet):`
`620`	`620`	`serializer_class = LineItemSerializer`
`621`	`621`
`622`	`622`	`def get_queryset(self):`
`623`		`- queryset = super(LineItemViewSet, self).get_queryset()`
	`623`	`+ queryset = super().get_queryset()`
`624`	`624`
`625`	`625`	`# if this viewset is accessed via the 'order-lineitems-list' route,`
`626`	`626`	# it wll have been passed the `order_pk` kwarg and the queryset
`627`	`627`	`# needs to be filtered accordingly; if it was accessed via the`
`628`	`628`	`# unnested '/lineitems' route, the queryset should include all LineItems`
`629`		`- if'order_pk'in self.kwargs:`
`630`		`- order_pk =self.kwargs['order_pk']`
	`629`	`+ order_pk= self.kwargs.get('order_pk')`
	`630`	`+ iforder_pk isnotNone:`
`631`	`631`	`queryset = queryset.filter(order__pk=order_pk)`
`632`	`632`
`633`	`633`	`return queryset`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -243,11 +243,13 @@ class CommentViewSet(ModelViewSet):`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`def get_queryset(self, args, *kwargs):`
	`246`	`+ queryset = super().get_queryset()`
	`247`	`+`
`246`	`248`	`entry_pk = self.kwargs.get("entry_pk", None)`
`247`	`249`	`if entry_pk is not None:`
`248`		`- returnself.queryset.filter(entry_id=entry_pk)`
	`250`	`+ queryset=queryset.filter(entry_id=entry_pk)`
`249`	`251`
`250`		`- return super(CommentViewSet, self).get_queryset()`
	`252`	`+ return queryset`
`251`	`253`
`252`	`254`
`253`	`255`	`class CompanyViewset(ModelViewSet):`

Comments

(0)