Skip to content

Navigation Menu

Sign in
Sign up
This repository was archived by the owner on Nov 27, 2021. It is now read-only.
This repository was archived by the owner on Nov 27, 2021. It is now read-only.

hard-coded hiera settings? #12

Open

Description

Hi, if I read your code correctly, there are hardcoded values from hiera in templates... omg this is so wrong.... what if I need to define for example hostrelay in puppet class?

for example having customized hiera config:

custom::postfix::package_ensure: 'latest'
custom::postfix::relayhost: 'smtp1.prod.cnc'

and defined class for it:

class custom::postfix ($package_ensure, $relayhost) {
 
 class { 'postfix':
 package_ensure => $package_ensure,
 relayhost => 'smtp1.prod.cnc',
 }
}

but this doesn't work because your module expects only one exact hiera structure and even it uses class parameters with it's default values it never uses them in erb templates! this could be quite nice, almost dependency free module, but this really sucks :-(
Please, make it more flexible by using internal variables which you already have defined.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      AltStyle によって変換されたページ (->オリジナル) /