Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit d5a2efb

Browse files
Fix memory leak in CountOccurrences routine
Also updated UMathsCatSnippets unit in Cat-Maths test project with revised CountOccurrences snippet. Fixes #54
1 parent 1f7ecbb commit d5a2efb

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

‎collection/699.dat

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ var
77

88
procedure SortResult(
99
var A: array of Generics.Collections.TPair<Integer,Cardinal>);
10-
begin
11-
Generics.Collections.TArray.Sort<
10+
var
11+
Comparer: Generics.Defaults.IComparer<
1212
Generics.Collections.TPair<Integer,Cardinal>
13-
>(
14-
A,
15-
Generics.Defaults.TDelegatedComparer<
13+
>;
14+
begin
15+
Comparer := Generics.Defaults.TDelegatedComparer<
1616
Generics.Collections.TPair<Integer,Cardinal>
1717
>.Create(
1818
function (
@@ -21,8 +21,10 @@ var
2121
begin
2222
Result := Left.Key - Right.Key;
2323
end
24-
)
25-
);
24+
);
25+
Generics.Collections.TArray.Sort<
26+
Generics.Collections.TPair<Integer,Cardinal>
27+
>(A, Comparer);
2628
end;
2729

2830
begin

‎tests/Cat-Maths/UMathsCatSnippets.pas

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1204,12 +1204,12 @@ function CountOccurrences(const A: array of Integer):
12041204

12051205
procedure SortResult(
12061206
var A: array of Generics.Collections.TPair<Integer,Cardinal>);
1207-
begin
1208-
Generics.Collections.TArray.Sort<
1207+
var
1208+
Comparer: Generics.Defaults.IComparer<
12091209
Generics.Collections.TPair<Integer,Cardinal>
1210-
>(
1211-
A,
1212-
Generics.Defaults.TDelegatedComparer<
1210+
>;
1211+
begin
1212+
Comparer := Generics.Defaults.TDelegatedComparer<
12131213
Generics.Collections.TPair<Integer,Cardinal>
12141214
>.Create(
12151215
function (
@@ -1218,8 +1218,10 @@ function CountOccurrences(const A: array of Integer):
12181218
begin
12191219
Result := Left.Key - Right.Key;
12201220
end
1221-
)
1222-
);
1221+
);
1222+
Generics.Collections.TArray.Sort<
1223+
Generics.Collections.TPair<Integer,Cardinal>
1224+
>(A, Comparer);
12231225
end;
12241226

12251227
begin

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /