Commit 87fa2e8

authored

fix: do not tread negative values as identifiers in the animation shorthand (#68)

1 parent 7f06bbb commit 87fa2e8Copy full SHA for 87fa2e8

File tree

+16

-1

lines changed

+16

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ function localizeDeclaration(declaration, context) {`
`357`	`357`
`358`	`358`	// We don't validate `hex digits`, because we don't need it, it is work of linters.
`359`	`359`	`const validIdent =`
`360`		`- /^-?([a-z\u0080-\uFFFF_]\|(\\[^\r\n\f])\|-)((\\[^\r\n\f])\|[a-z\u0080-\uFFFF_0-9-])*$/i;`
	`360`	`+ /^-?([a-z\u0080-\uFFFF_]\|(\\[^\r\n\f])\|-(?![0-9]))((\\[^\r\n\f])\|[a-z\u0080-\uFFFF_0-9-])*$/i;`
`361`	`361`
`362`	`362`	`/*`
`363`	`363`	`The spec defines some keywords that you can use to describe properties such as the timing`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -864,6 +864,21 @@ const tests = [`
`864`	`864`	`options: { mode: "pure" },`
`865`	`865`	`expected: ":export { foo: __foo; }",`
`866`	`866`	`},`
	`867`	`+ {`
	`868`	`+ name: "handle negative animation-delay in animation shorthand",`
	`869`	`+ input: ".foo { animation: 1s -500ms; }",`
	`870`	`+ expected: ":local(.foo) { animation: 1s -500ms; }",`
	`871`	`+ },`
	`872`	`+ {`
	`873`	`+ name: "handle negative animation-delay in animation shorthand #1",`
	`874`	`+ input: ".foo { animation: 1s -500.0ms; }",`
	`875`	`+ expected: ":local(.foo) { animation: 1s -500.0ms; }",`
	`876`	`+ },`
	`877`	`+ {`
	`878`	`+ name: "handle negative animation-delay in animation shorthand #2",`
	`879`	`+ input: ".foo { animation: 1s -500.0ms -a_value; }",`
	`880`	`+ expected: ":local(.foo) { animation: 1s -500.0ms :local(-a_value); }",`
	`881`	`+ },`
`867`	`882`	`];`
`868`	`883`
`869`	`884`	`function process(css, options) {`

Comments

(0)