Commit b8f648f

authored

Remove virtualservice retries for realtime and traffic splitter APIs (#2419)

1 parent 3b7b1fc commit b8f648fCopy full SHA for b8f648f

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ type VirtualServiceSpec struct {`
`45`	`45`	`Labels map[string]string`
`46`	`46`	`Annotations map[string]string`
`47`	`47`	`Headers *istionetworking.Headers`
	`48`	`+ Retries *int32`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`type Destination struct {`
`@@ -153,6 +154,14 @@ func VirtualService(spec VirtualServiceSpec) istioclientnetworking.VirtualServ`
`153`	`154`	`httpRoutes = append(httpRoutes, exactMatch, prefixMatch)`
`154`	`155`	`}`
`155`	`156`
	`157`	`+ if spec.Retries != nil {`
	`158`	`+ for i := range httpRoutes {`
	`159`	`+ httpRoutes[i].Retries = &istionetworking.HTTPRetry{`
	`160`	`+ Attempts: *spec.Retries,`
	`161`	`+ }`
	`162`	`+ }`
	`163`	`+ }`
	`164`	`+`
`156`	`165`	`virtualService := &istioclientnetworking.VirtualService{`
`157`	`166`	`TypeMeta: _virtualServiceTypeMeta,`
`158`	`167`	`ObjectMeta: kmeta.ObjectMeta{`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,7 @@ func virtualServiceSpec(api spec.API) istioclientnetworking.VirtualService {`
`149`	`149`	`},`
`150`	`150`	`PrefixPath: api.Networking.Endpoint,`
`151`	`151`	`Rewrite: pointer.String("/"),`
	`152`	`+ Retries: pointer.Int32(0),`
`152`	`153`	`Annotations: api.ToK8sAnnotations(),`
`153`	`154`	`Labels: map[string]string{`
`154`	`155`	`"apiName": api.Name,`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ func virtualServiceSpec(trafficSplitter spec.API) istioclientnetworking.Virtua`
`32`	`32`	`Destinations: getTrafficSplitterDestinations(trafficSplitter),`
`33`	`33`	`ExactPath: trafficSplitter.Networking.Endpoint,`
`34`	`34`	`Rewrite: pointer.String("/"),`
	`35`	`+ Retries: pointer.Int32(0),`
`35`	`36`	`Annotations: trafficSplitter.ToK8sAnnotations(),`
`36`	`37`	`Labels: map[string]string{`
`37`	`38`	`"apiName": trafficSplitter.Name,`

Comments

(0)