Commit e571970

authored

feat(config-pnpm-scopes): allow global scope (#4553)

1 parent 407be6c commit e571970Copy full SHA for e571970

File tree

+14

-13

lines changed

+14

-13

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,19 +51,19 @@ test("scope-enum has expected modifier", async () => {`
`51`	`51`	`expect(modifier).toBe("always");`
`52`	`52`	`});`
`53`	`53`
`54`		`-test("returns empty value for empty pnpm repository", async () => {`
	`54`	`+test("returns global scope for empty pnpm repository", async () => {`
`55`	`55`	`const { "scope-enum": fn } = config.rules;`
`56`	`56`	`const cwd = await npm.bootstrap("fixtures/empty", __dirname);`
`57`	`57`	`const [, , value] = await fn({ cwd });`
`58`		`- expect(value).toEqual([]);`
	`58`	`+ expect(value).toEqual(["global"]);`
`59`	`59`	`});`
`60`	`60`
`61`	`61`	`test("returns expected value for basic pnpm repository", async () => {`
`62`	`62`	`const { "scope-enum": fn } = config.rules;`
`63`	`63`	`const cwd = await npm.bootstrap("fixtures/basic", __dirname);`
`64`	`64`
`65`	`65`	`const [, , value] = await fn({ cwd });`
`66`		`- expect(value).toEqual(["a", "b"]);`
	`66`	`+ expect(value).toEqual(["a", "b","global"]);`
`67`	`67`	`});`
`68`	`68`
`69`	`69`	`test("returns expected value for scoped pnpm repository", async () => {`
`@@ -72,5 +72,5 @@ test("returns expected value for scoped pnpm repository", async () => {`
`72`	`72`
`73`	`73`	`const [, , value] = await fn({ cwd });`
`74`	`74`
`75`		`- expect(value).toEqual(["a", "b"]);`
	`75`	`+ expect(value).toEqual(["a", "b","global"]);`
`76`	`76`	`});`

Lines changed: 10 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,16 +69,17 @@ function getProjects(context: any) {`
`69`	`69`	`const cwd = ctx.cwd \|\| process.cwd();`
`70`	`70`
`71`	`71`	`return findWorkspacePackages(cwd).then((projects: any) => {`
`72`		`- return projects`
`73`		`- .reduce((projects: any, project: any) => {`
`74`		`- const name = project.name;`
	`72`	`+ const scopes = projects.reduce((acc: any, project: any) => {`
	`73`	`+ const name = project.name;`
`75`	`74`
`76`		`- if (name) {`
`77`		`- projects.push(name.charAt(0) === "@" ? name.split("/")[1] : name);`
`78`		`- }`
	`75`	`+ if (name) {`
	`76`	`+ acc.add(name.charAt(0) === "@" ? name.split("/")[1] : name);`
	`77`	`+ }`
	`78`	`+`
	`79`	`+ return acc;`
	`80`	`+ }, new Set());`
	`81`	`+ scopes.add("global");`
`79`	`82`
`80`		`- return projects;`
`81`		`- }, [])`
`82`		`- .sort();`
	`83`	`+ return Array.from(scopes).sort();`
`83`	`84`	`});`
`84`	`85`	`}`

Comments

(0)