Commit 69cfe80

authored

Rollup merge of rust-lang#123096 - compiler-errors:postfix-match-parens, r=fmease

Don't check match scrutinee of postfix match for unused parens We only check the scrutinees of block-like constructs and a few others (return/index/assign/method calls). Just don't do it for postfix match at all. Fixes rust-lang#123064 r? fmease

2 parents 732ded9 + 950b40f commit 69cfe80Copy full SHA for 69cfe80

File tree

2 files changed

+11

-1

lines changed

compiler/rustc_lint/src
- unused.rs
tests/ui/match/postfix-match
- no-unused-parens.rs

2 files changed

+11

-1

lines changed

`‎compiler/rustc_lint/src/unused.rs‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -865,7 +865,9 @@ trait UnusedDelimLint {`
`865`	`865`	`(iter, UnusedDelimsCtx::ForIterExpr, true, None, Some(body.span.lo()), true)`
`866`	`866`	`}`
`867`	`867`
`868`		`- Match(ref head, ..) if Self::LINT_EXPR_IN_PATTERN_MATCHING_CTX => {`
	`868`	`+ Match(ref head, _, ast::MatchKind::Prefix)`
	`869`	`+ if Self::LINT_EXPR_IN_PATTERN_MATCHING_CTX =>`
	`870`	`+ {`
`869`	`871`	`let left = e.span.lo() + rustc_span::BytePos(5);`
`870`	`872`	`(head, UnusedDelimsCtx::MatchScrutineeExpr, true, Some(left), None, true)`
`871`	`873`	`}`

`‎tests/ui/match/postfix-match/no-unused-parens.rs‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,8 @@`
	`1`	`+//@ check-pass`
	`2`	`+`
	`3`	`+#![feature(postfix_match)]`
	`4`	`+`
	`5`	`+fn main() {`
	`6`	`+ (&1).match { a => a };`
	`7`	`+ (1 + 2).match { b => b };`
	`8`	`+}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 69cfe80

File tree

2 files changed

2 files changed

`‎compiler/rustc_lint/src/unused.rs‎`

`‎tests/ui/match/postfix-match/no-unused-parens.rs‎`

0 commit comments