Commit e3d474b

committed

refactor: misc cleanup

1 parent a0cc490 commit e3d474bCopy full SHA for e3d474b

File tree

2 files changed

-18

lines changed

commitizen/cz
- conventional_commits
  - conventional_commits.py
- jira
  - jira.py

2 files changed

-18

lines changed

`‎commitizen/cz/conventional_commits/conventional_commits.py‎`

Lines changed: 7 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ class ConventionalCommitsCz(BaseCommitizen):`
`41`	`41`	`changelog_pattern = defaults.bump_pattern`
`42`	`42`
`43`	`43`	`def questions(self) -> Questions:`
`44`		`- questions: Questions= [`
	`44`	`+ return [`
`45`	`45`	`{`
`46`	`46`	`"type": "list",`
`47`	`47`	`"name": "prefix",`
`@@ -146,7 +146,6 @@ def questions(self) -> Questions:`
`146`	`146`	`),`
`147`	`147`	`},`
`148`	`148`	`]`
`149`		`- return questions`
`150`	`149`
`151`	`150`	`def message(self, answers: dict) -> str:`
`152`	`151`	`prefix = answers["prefix"]`
`@@ -165,9 +164,7 @@ def message(self, answers: dict) -> str:`
`165`	`164`	`if footer:`
`166`	`165`	`footer = f"\n\n{footer}"`
`167`	`166`
`168`		`- message = f"{prefix}{scope}: {subject}{body}{footer}"`
`169`		`-`
`170`		`- return message`
	`167`	`+ return f"{prefix}{scope}: {subject}{body}{footer}"`
`171`	`168`
`172`	`169`	`def example(self) -> str:`
`173`	`170`	`return (`
`@@ -188,25 +185,21 @@ def schema(self) -> str:`
`188`	`185`	`)`
`189`	`186`
`190`	`187`	`def schema_pattern(self) -> str:`
`191`		`- PATTERN= (`
	`188`	`+ return (`
`192`	`189`	`r"(?s)" # To explicitly make . match new line`
`193`	`190`	`r"(build\|ci\|docs\|feat\|fix\|perf\|refactor\|style\|test\|chore\|revert\|bump)" # type`
`194`	`191`	`r"($\S+$)?!?:" # scope`
`195`	`192`	`r"( [^\n\r]+)" # subject`
`196`	`193`	`r"((\n\n.)\|(\s))?$"`
`197`	`194`	`)`
`198`		`- return PATTERN`
`199`	`195`
`200`	`196`	`def info(self) -> str:`
`201`	`197`	`dir_path = os.path.dirname(os.path.realpath(__file__))`
`202`	`198`	`filepath = os.path.join(dir_path, "conventional_commits_info.txt")`
`203`	`199`	`with open(filepath, encoding=self.config.settings["encoding"]) as f:`
`204`		`- content = f.read()`
`205`		`- return content`
	`200`	`+ return f.read()`
`206`	`201`
`207`	`202`	`def process_commit(self, commit: str) -> str:`
`208`		`- pat = re.compile(self.schema_pattern())`
`209`		`- m = re.match(pat, commit)`
`210`		`- if m is None:`
`211`		`- return ""`
`212`		`- return m.group(3).strip()`
	`203`	`+ if m := re.match(self.schema_pattern(), commit):`
	`204`	`+ return m.group(3).strip()`
	`205`	`+ return ""`

`‎commitizen/cz/jira/jira.py‎`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`class JiraSmartCz(BaseCommitizen):`
`10`	`10`	`def questions(self) -> Questions:`
`11`		`- questions= [`
	`11`	`+ return [`
`12`	`12`	`{`
`13`	`13`	`"type": "input",`
`14`	`14`	`"name": "message",`
`@@ -42,7 +42,6 @@ def questions(self) -> Questions:`
`42`	`42`	`"filter": lambda x: "#comment " + x if x else "",`
`43`	`43`	`},`
`44`	`44`	`]`
`45`		`- return questions`
`46`	`45`
`47`	`46`	`def message(self, answers: dict) -> str:`
`48`	`47`	`return " ".join(`
`@@ -77,5 +76,4 @@ def info(self) -> str:`
`77`	`76`	`dir_path = os.path.dirname(os.path.realpath(__file__))`
`78`	`77`	`filepath = os.path.join(dir_path, "jira_info.txt")`
`79`	`78`	`with open(filepath, encoding=self.config.settings["encoding"]) as f:`
`80`		`- content = f.read()`
`81`		`- return content`
	`79`	`+ return f.read()`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit e3d474b

File tree

2 files changed

2 files changed

`‎commitizen/cz/conventional_commits/conventional_commits.py‎`

`‎commitizen/cz/jira/jira.py‎`

0 commit comments