Commit ca0f250

bearomorphismLee-W

authored and

committed

refactor(git): retype get_commits parameter to make it more friendly to call sites

1 parent 542d46b commit ca0f250Copy full SHA for ca0f250

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -253,10 +253,7 @@ def __call__(self) -> None:`
`253`	`253`	`) from exc`
`254`	`254`	`else:`
`255`	`255`	`if increment is None:`
`256`		`- if current_tag:`
`257`		`- commits = git.get_commits(current_tag.name)`
`258`		`- else:`
`259`		`- commits = git.get_commits()`
	`256`	`+ commits = git.get_commits(current_tag.name if current_tag else None)`
`260`	`257`
`261`	`258`	`# No commits, there is no need to create an empty tag.`
`262`	`259`	`# Unless we previously had a prerelease.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ def _get_commits(self) -> list[git.GitCommit]:`
`110`	`110`	`return [git.GitCommit(rev="", title="", body=self._filter_comments(msg))]`
`111`	`111`
`112`	`112`	`# Get commit messages from git log (--rev-range)`
`113`		`- return git.get_commits(end=self.rev_rangeor"HEAD")`
	`113`	`+ return git.get_commits(end=self.rev_range)`
`114`	`114`
`115`	`115`	`@staticmethod`
`116`	`116`	`def _filter_comments(msg: str) -> str:`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -201,15 +201,18 @@ def _create_commit_cmd_string(args: str, committer_date: str \| None, name: str)`
`201`	`201`
`202`	`202`	`def get_commits(`
`203`	`203`	`start: str \| None = None,`
`204`		`- end: str ="HEAD",`
	`204`	`+ end: str \|None=None,`
`205`	`205`	`*,`
`206`	`206`	`args: str = "",`
`207`	`207`	`) -> list[GitCommit]:`
`208`	`208`	`"""Get the commits between start and end."""`
	`209`	`+ if end is None:`
	`210`	`+ end = "HEAD"`
`209`	`211`	`git_log_entries = _get_log_as_str_list(start, end, args)`
`210`	`212`	`return [`
`211`	`213`	`GitCommit.from_rev_and_commit(rev_and_commit)`
`212`		`- for rev_and_commit in filter(None, git_log_entries)`
	`214`	`+ for rev_and_commit in git_log_entries`
	`215`	`+ if rev_and_commit`
`213`	`216`	`]`
`214`	`217`
`215`	`218`

Comments

(0)