Commit b7b96f6

committed

fix: improve errors message when empty .cz.json found

Closes #576

1 parent b0d8778 commit b7b96f6Copy full SHA for b7b96f6

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`import json`
`2`	`2`	`from pathlib import Path`
`3`	`3`	`from typing import Union`
	`4`	`+from commitizen.exceptions import InvalidConfigurationError`
`4`	`5`
`5`	`6`	`from commitizen.git import smart_open`
`6`	`7`
`@@ -11,8 +12,8 @@ class JsonConfig(BaseConfig):`
`11`	`12`	`def __init__(self, *, data: Union[bytes, str], path: Union[Path, str]):`
`12`	`13`	`super(JsonConfig, self).__init__()`
`13`	`14`	`self.is_empty_config = False`
`14`		`- self._parse_setting(data)`
`15`	`15`	`self.add_path(path)`
	`16`	`+ self._parse_setting(data)`
`16`	`17`
`17`	`18`	`def init_empty_config_content(self):`
`18`	`19`	`with smart_open(self.path, "a") as json_file:`
`@@ -43,7 +44,11 @@ def _parse_setting(self, data: Union[bytes, str]) -> None:`
`43`	`44`	`}`
`44`	`45`	```
`45`	`46`	`"""`
`46`		`- doc = json.loads(data)`
	`47`	`+ try:`
	`48`	`+ doc = json.loads(data)`
	`49`	`+ except json.JSONDecodeError:`
	`50`	`+ raise InvalidConfigurationError(f"Failed to parse {self.path}")`
	`51`	`+`
`47`	`52`	`try:`
`48`	`53`	`self.settings.update(doc["commitizen"])`
`49`	`54`	`except KeyError:`

Comments

(0)