Commit a23ef07

BogayLee-W

authored and

committed

fix(init): space between --hook-type options

there should be a space between `--hook-type` options in generated `pre-commit` command string.

1 parent 599c10f commit a23ef07Copy full SHA for a23ef07

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ def _gen_pre_commit_cmd(self, hook_types: List[str]) -> str:`
`140`	`140`	`"""Generate pre-commit command according to given hook types"""`
`141`	`141`	`if not hook_types:`
`142`	`142`	`raise ValueError("At least 1 hook type should be provided.")`
`143`		`- cmd_str = "pre-commit install " + "".join(`
	`143`	`+ cmd_str = "pre-commit install " + "".join(`
`144`	`144`	`f"--hook-type {ty}" for ty in hook_types`
`145`	`145`	`)`
`146`	`146`	`return cmd_str`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,12 @@ def test_init_without_choosing_tag(config, mocker: MockFixture, tmpdir):`
`99`	`99`	`commands.Init(config)()`
`100`	`100`
`101`	`101`
	`102`	`+def test_executed_pre_commit_command(config):`
	`103`	`+ init = commands.Init(config)`
	`104`	`+ expected_cmd = "pre-commit install --hook-type commit-msg --hook-type pre-push"`
	`105`	`+ assert init._gen_pre_commit_cmd(["commit-msg", "pre-push"]) == expected_cmd`
	`106`	`+`
	`107`	`+`
`102`	`108`	`@pytest.fixture(scope="function")`
`103`	`109`	`def pre_commit_installed(mocker: MockFixture):`
`104`	`110`	# Assume the `pre-commit` is installed

Comments

(0)