Commit 991e829

committed

fix(git): Improves error checking in get_tags

`git tag` is has return code of zero whether or not tags exist so we should always expect the code to be zero.

1 parent 91ed065 commit 991e829Copy full SHA for 991e829

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`from tempfile import NamedTemporaryFile`
`6`	`6`	`from typing import List, Optional`
`7`	`7`
`8`		`-from commitizen import cmd`
	`8`	`+from commitizen import cmd, out`
`9`	`9`	`from commitizen.exceptions import GitCommandError`
`10`	`10`
`11`	`11`	`UNIX_EOL = "\n"`
`@@ -150,8 +150,13 @@ def get_tags(dateformat: str = "%Y-%m-%d") -> List[GitTag]:`
`150`	`150`	`f'%(object)"'`
`151`	`151`	`)`
`152`	`152`	`c = cmd.run(f"git tag --format={formatter} --sort=-creatordate")`
	`153`	`+ if c.return_code != 0:`
	`154`	`+ raise GitCommandError(c.err)`
`153`	`155`
`154`		`- if c.err or not c.out:`
	`156`	`+ if c.err:`
	`157`	`+ out.warn(f"Attempting to proceed after: {c.err}")`
	`158`	`+`
	`159`	`+ if not c.out:`
`155`	`160`	`return []`
`156`	`161`
`157`	`162`	`git_tags = [`

Comments

(0)