Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 92a92bc

Browse files
style(changelog): rename parameter for consistency
1 parent 9b99924 commit 92a92bc

File tree

1 file changed

+19
-14
lines changed

1 file changed

+19
-14
lines changed

‎commitizen/commands/changelog.py‎

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ class ChangelogArgs(TypedDict, total=False):
4747
class Changelog:
4848
"""Generate a changelog based on the commit history."""
4949

50-
def __init__(self, config: BaseConfig, args: ChangelogArgs) -> None:
50+
def __init__(self, config: BaseConfig, arguments: ChangelogArgs) -> None:
5151
if not git.is_git_project():
5252
raise NotAGitProjectError()
5353

5454
self.config = config
5555

56-
changelog_file_name = args.get("file_name") or self.config.settings.get(
56+
changelog_file_name = arguments.get("file_name") or self.config.settings.get(
5757
"changelog_file"
5858
)
5959
if not isinstance(changelog_file_name, str):
@@ -71,27 +71,30 @@ def __init__(self, config: BaseConfig, args: ChangelogArgs) -> None:
7171
self.encoding = self.config.settings["encoding"]
7272
self.cz = factory.committer_factory(self.config)
7373

74-
self.start_rev = args.get("start_rev") or self.config.settings.get(
74+
self.start_rev = arguments.get("start_rev") or self.config.settings.get(
7575
"changelog_start_rev"
7676
)
7777

7878
self.changelog_format = get_changelog_format(self.config, self.file_name)
7979

8080
self.incremental = bool(
81-
args.get("incremental") or self.config.settings.get("changelog_incremental")
81+
arguments.get("incremental")
82+
or self.config.settings.get("changelog_incremental")
8283
)
83-
self.dry_run = bool(args.get("dry_run"))
84+
self.dry_run = bool(arguments.get("dry_run"))
8485

8586
self.scheme = get_version_scheme(
86-
self.config.settings, args.get("version_scheme")
87+
self.config.settings, arguments.get("version_scheme")
8788
)
8889

8990
current_version = (
90-
args.get("current_version") or self.config.settings.get("version") or ""
91+
arguments.get("current_version")
92+
or self.config.settings.get("version")
93+
or ""
9194
)
9295
self.current_version = self.scheme(current_version) if current_version else None
9396

94-
self.unreleased_version = args["unreleased_version"]
97+
self.unreleased_version = arguments["unreleased_version"]
9598
self.change_type_map = (
9699
self.config.settings.get("change_type_map") or self.cz.change_type_map
97100
)
@@ -101,24 +104,26 @@ def __init__(self, config: BaseConfig, args: ChangelogArgs) -> None:
101104
or self.cz.change_type_order
102105
or defaults.CHANGE_TYPE_ORDER,
103106
)
104-
self.rev_range = args.get("rev_range")
105-
self.tag_format = args.get("tag_format") or self.config.settings["tag_format"]
107+
self.rev_range = arguments.get("rev_range")
108+
self.tag_format = (
109+
arguments.get("tag_format") or self.config.settings["tag_format"]
110+
)
106111
self.tag_rules = TagRules(
107112
scheme=self.scheme,
108113
tag_format=self.tag_format,
109114
legacy_tag_formats=self.config.settings["legacy_tag_formats"],
110115
ignored_tag_formats=self.config.settings["ignored_tag_formats"],
111-
merge_prereleases=args.get("merge_prerelease")
116+
merge_prereleases=arguments.get("merge_prerelease")
112117
or self.config.settings["changelog_merge_prerelease"],
113118
)
114119

115120
self.template = (
116-
args.get("template")
121+
arguments.get("template")
117122
or self.config.settings.get("template")
118123
or self.changelog_format.template
119124
)
120-
self.extras = args.get("extras") or {}
121-
self.export_template_to = args.get("export_template")
125+
self.extras = arguments.get("extras") or {}
126+
self.export_template_to = arguments.get("export_template")
122127

123128
def _find_incremental_rev(self, latest_version: str, tags: Iterable[GitTag]) -> str:
124129
"""Try to find the 'start_rev'.

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /