Commit 8cf7acd

bearomorphismLee-W

authored and

committed

refactor(ScmProvider): replace sorted with max

1 parent 56ef1e0 commit 8cf7acdCopy full SHA for 8cf7acd

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,8 @@ def get_version(self) -> str:`
`18`	`18`	`rules = TagRules.from_settings(self.config.settings)`
`19`	`19`	`tags = get_tags(reachable_only=True)`
`20`	`20`	`version_tags = rules.get_version_tags(tags)`
`21`		`- versions = sorted(rules.extract_version(t) for t in version_tags)`
`22`		`- if not versions:`
`23`		`- return "0.0.0"`
`24`		`- return str(versions[-1])`
	`21`	`+ version = max((rules.extract_version(t) for t in version_tags), default=None)`
	`22`	`+ return str(version) if version is not None else "0.0.0"`
`25`	`23`
`26`	`24`	`def set_version(self, version: str) -> None:`
`27`	`25`	`# Not necessary`

Comments

(0)