Commit 75c9f56

SCrockySCrocky

authored and

SCrocky

committed

refactor(Commit): Added deprecation on git signoff mechanic

Signoff dedicated code is no longer necessary & removed #TODO as tests show identical args and extra-args are not an issue.

1 parent 37a118e commit 75c9f56Copy full SHA for 75c9f56

File tree

-1

lines changed

-1

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,6 @@ def main():`
`434`	`434`	`raise InvalidCommandArgumentError(`
`435`	`435`	f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
`436`	`436`	`)`
`437`		`- # TODO: treat case when extra-args and commitizen args are identical`
`438`	`437`	`extra_args = " ".join(unknown_args[1:])`
`439`	`438`	`arguments["extra_cli_args"] = extra_args`
`440`	`439`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ def __call__(self):`
`91`	`91`	`signoff: bool = self.arguments.get("signoff")`
`92`	`92`
`93`	`93`	`if signoff:`
	`94`	+ out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
`94`	`95`	`c = git.commit(m, "-s")`
`95`	`96`
`96`	`97`	`if self.arguments.get("extra_cli_args"):`

Comments

(0)