Commit 600f96a

committed

refactor(Commit): Added deprecation on git signoff mechanic

Signoff dedicated code is no longer necessary & removed #TODO as tests show identical args and extra-args are not an issue.

1 parent fc81dc8 commit 600f96aCopy full SHA for 600f96a

File tree

-1

lines changed

-1

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,6 @@ def main():`
`398`	`398`	`raise InvalidCommandArgumentError(`
`399`	`399`	f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
`400`	`400`	`)`
`401`		`- # TODO: treat case when extra-args and commitizen args are identical`
`402`	`401`	`extra_args = " ".join(unknown_args[1:])`
`403`	`402`	`arguments["extra_cli_args"] = extra_args`
`404`	`403`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ def __call__(self):`
`82`	`82`	`signoff: bool = self.arguments.get("signoff")`
`83`	`83`
`84`	`84`	`if signoff:`
	`85`	+ out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
`85`	`86`	`c = git.commit(m, "-s")`
`86`	`87`
`87`	`88`	`if self.arguments.get("extra_cli_args"):`

Comments

(0)