Commit 5318325

committed

test(changelog): fixes logic issue made evident by latest fix(git) commit

Exception is raised by git error: "fatal: your current branch 'master' does not have any commits yet". This response is more informative than the original "No commits found" exception and the "fail fast" logic is a bit easier to follow.

1 parent 9b243a3 commit 5318325Copy full SHA for 5318325

File tree

1 file changed

-2

lines changed

tests/commands
- test_changelog_command.py

1 file changed

-2

lines changed

`‎tests/commands/test_changelog_command.py‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`from commitizen.commands.changelog import Changelog`
`7`	`7`	`from commitizen.exceptions import (`
`8`	`8`	`DryRunExit,`
	`9`	`+ GitCommandError,`
`9`	`10`	`NoCommitsFoundError,`
`10`	`11`	`NoRevisionError,`
`11`	`12`	`NotAGitProjectError,`
`@@ -19,10 +20,12 @@ def test_changelog_on_empty_project(mocker):`
`19`	`20`	`testargs = ["cz", "changelog", "--dry-run"]`
`20`	`21`	`mocker.patch.object(sys, "argv", testargs)`
`21`	`22`
`22`		`- with pytest.raises(NoCommitsFoundError) asexcinfo:`
	`23`	`+ with pytest.raises(GitCommandError):`
`23`	`24`	`cli.main()`
`24`	`25`
`25`		`- assert "No commits found" in str(excinfo)`
	`26`	`+ # git will error out with something like:`
	`27`	`+ # "your current branch 'XYZ' does not have any commits yet"`
	`28`	`+ # is it wise to assert the exception contains a message like this?`
`26`	`29`
`27`	`30`
`28`	`31`	`@pytest.mark.usefixtures("tmp_commitizen_project")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 5318325

File tree

1 file changed

1 file changed

`‎tests/commands/test_changelog_command.py‎`

0 commit comments