Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 34a4836

Browse files
bearomorphismLee-W
authored andcommitted
refactor(changelog): shorten condition expression and early return
1 parent 38397b2 commit 34a4836

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

‎commitizen/changelog.py‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ def incremental_build(
251251
unreleased_start = metadata.unreleased_start
252252
unreleased_end = metadata.unreleased_end
253253
latest_version_position = metadata.latest_version_position
254+
254255
skip = False
255256
output_lines: list[str] = []
256257
for index, line in enumerate(lines):
@@ -260,9 +261,7 @@ def incremental_build(
260261
skip = False
261262
if (
262263
latest_version_position is None
263-
or isinstance(latest_version_position, int)
264-
and isinstance(unreleased_end, int)
265-
and latest_version_position > unreleased_end
264+
or latest_version_position > unreleased_end
266265
):
267266
continue
268267

@@ -271,13 +270,15 @@ def incremental_build(
271270

272271
if index == latest_version_position:
273272
output_lines.extend([new_content, "\n"])
274-
275273
output_lines.append(line)
276-
if not isinstance(latest_version_position, int):
277-
if output_lines and output_lines[-1].strip():
278-
# Ensure at least one blank line between existing and new content.
279-
output_lines.append("\n")
280-
output_lines.append(new_content)
274+
275+
if latest_version_position is not None:
276+
return output_lines
277+
278+
if output_lines and output_lines[-1].strip():
279+
# Ensure at least one blank line between existing and new content.
280+
output_lines.append("\n")
281+
output_lines.append(new_content)
281282
return output_lines
282283

283284

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /