Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 316579c

Browse files
refactor(customize): improve code readability
1 parent 617b610 commit 316579c

File tree

1 file changed

+13
-29
lines changed

1 file changed

+13
-29
lines changed

‎commitizen/cz/customize/customize.py‎

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,35 +21,24 @@
2121

2222

2323
class CustomizeCommitsCz(BaseCommitizen):
24-
bump_pattern = defaults.bump_pattern
25-
bump_map = defaults.bump_map
26-
bump_map_major_version_zero = defaults.bump_map_major_version_zero
27-
change_type_order = defaults.change_type_order
28-
2924
def __init__(self, config: BaseConfig):
3025
super().__init__(config)
3126

3227
if "customize" not in self.config.settings:
3328
raise MissingCzCustomizeConfigError()
3429
self.custom_settings = self.config.settings["customize"]
3530

36-
custom_bump_pattern = self.custom_settings.get("bump_pattern")
37-
ifcustom_bump_pattern:
38-
self.bump_pattern=custom_bump_pattern
39-
40-
custom_bump_map = self.custom_settings.get("bump_map")
41-
ifcustom_bump_map:
42-
self.bump_map=custom_bump_map
43-
44-
custom_bump_map_major_version_zero = self.custom_settings.get(
45-
"bump_map_major_version_zero"
31+
self.bump_pattern = (
32+
self.custom_settings.get("bump_pattern") ordefaults.bump_pattern
33+
)
34+
self.bump_map=self.custom_settings.get("bump_map") ordefaults.bump_map
35+
self.bump_map_major_version_zero = (
36+
self.custom_settings.get("bump_map_major_version_zero")
37+
ordefaults.bump_map_major_version_zero
38+
)
39+
self.change_type_order = (
40+
self.custom_settings.get("change_type_order") ordefaults.change_type_order
4641
)
47-
if custom_bump_map_major_version_zero:
48-
self.bump_map_major_version_zero = custom_bump_map_major_version_zero
49-
50-
custom_change_type_order = self.custom_settings.get("change_type_order")
51-
if custom_change_type_order:
52-
self.change_type_order = custom_change_type_order
5342

5443
commit_parser = self.custom_settings.get("commit_parser")
5544
if commit_parser:
@@ -83,12 +72,7 @@ def schema(self) -> str:
8372
return self.custom_settings.get("schema") or ""
8473

8574
def info(self) -> str:
86-
info_path = self.custom_settings.get("info_path")
87-
info = self.custom_settings.get("info")
88-
if info_path:
75+
if info_path := self.custom_settings.get("info_path"):
8976
with open(info_path, encoding=self.config.settings["encoding"]) as f:
90-
content = f.read()
91-
return content
92-
elif info:
93-
return info
94-
return ""
77+
return f.read()
78+
return self.custom_settings.get("info") or ""

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /