Commit 2a8a8ea

oed-gubinaLee-W

authored and

committed

fix(commit): use os.unlink to remove temp file

NamedTemporaryFile doesn't have a unlink function when delete=False is used Fix #1352

1 parent af28565 commit 2a8a8eaCopy full SHA for 2a8a8ea

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ def manual_edit(self, message: str) -> str:`
`89`	`89`	`subprocess.call(argv)`
`90`	`90`	`with open(file_path) as temp_file:`
`91`	`91`	`message = temp_file.read().strip()`
`92`		`- file.unlink()`
	`92`	`+ os.unlink(file.name)`
`93`	`93`	`return message`
`94`	`94`
`95`	`95`	`def __call__(self):`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -511,8 +511,6 @@ def test_manual_edit(editor, config, mocker: MockFixture, tmp_path):`
`511`	`511`
`512`	`512`	`assert edited_message == test_message.strip()`
`513`	`513`
`514`		`- temp_file.unlink()`
`515`		`-`
`516`	`514`
`517`	`515`	`@skip_below_py_3_13`
`518`	`516`	`def test_commit_command_shows_description_when_use_help_option(`

Comments

(0)