Commit 19efaa8

committed

refactor: remove unnecessary bool() and remove Any type from TypedDict get

1 parent 95a9140 commit 19efaa8Copy full SHA for 19efaa8

File tree

2 files changed

-7

lines changed

commitizen
- commands
  - bump.py
- defaults.py

2 files changed

-7

lines changed

`‎commitizen/commands/bump.py‎`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@`
`40`	`40`	`class BumpArgs(Settings, total=False):`
`41`	`41`	`allow_no_commit: bool \| None`
`42`	`42`	`annotated_tag_message: str \| None`
`43`		`- annotated_tag: bool`
`44`	`43`	`build_metadata: str \| None`
`45`	`44`	`changelog_to_stdout: bool`
`46`	`45`	`changelog: bool`
`@@ -51,7 +50,6 @@ class BumpArgs(Settings, total=False):`
`51`	`50`	`files_only: bool \| None`
`52`	`51`	`get_next: bool`
`53`	`52`	`git_output_to_stderr: bool`
`54`		`- gpg_sign: bool`
`55`	`53`	`increment_mode: str`
`56`	`54`	`increment: Increment \| None`
`57`	`55`	`local_version: bool`
`@@ -222,7 +220,7 @@ def __call__(self) -> None:`
`222`	`220`
`223`	`221`	`if get_next:`
`224`	`222`	`# if trying to use --get-next, we should not allow --changelog or --changelog-to-stdout`
`225`		`- if self.changelog_flag or bool(self.changelog_to_stdout):`
	`223`	`+ if self.changelog_flag or self.changelog_to_stdout:`
`226`	`224`	`raise NotAllowed(`
`227`	`225`	`"--changelog or --changelog-to-stdout is not allowed with --get-next"`
`228`	`226`	`)`
`@@ -234,9 +232,7 @@ def __call__(self) -> None:`
`234`	`232`	`# If user specified changelog_to_stdout, they probably want the`
`235`	`233`	`# changelog to be generated as well, this is the most intuitive solution`
`236`	`234`	`self.changelog_flag = bool(`
`237`		`- self.changelog_flag`
`238`		`- or bool(self.changelog_to_stdout)`
`239`		`- or self.changelog_config`
	`235`	`+ self.changelog_flag or self.changelog_to_stdout or self.changelog_config`
`240`	`236`	`)`
`241`	`237`
`242`	`238`	`rules = TagRules.from_settings(cast(Settings, self.bump_settings))`

`‎commitizen/defaults.py‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,16 +32,18 @@ class Settings(TypedDict, total=False):`
`32`	`32`	`allow_abort: bool`
`33`	`33`	`allowed_prefixes: list[str]`
`34`	`34`	`always_signoff: bool`
	`35`	`+ annotated_tag: bool`
`35`	`36`	`bump_message: str \| None`
	`37`	`+ change_type_map: dict[str, str]`
`36`	`38`	`changelog_file: str`
`37`	`39`	`changelog_format: str \| None`
`38`	`40`	`changelog_incremental: bool`
`39`	`41`	`changelog_merge_prerelease: bool`
`40`		`- change_type_map: dict[str, str]`
`41`	`42`	`changelog_start_rev: str \| None`
`42`	`43`	`customize: CzSettings`
`43`	`44`	`encoding: str`
`44`	`45`	`extras: dict[str, Any]`
	`46`	`+ gpg_sign: bool`
`45`	`47`	`ignored_tag_formats: Sequence[str]`
`46`	`48`	`legacy_tag_formats: Sequence[str]`
`47`	`49`	`major_version_zero: bool`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 19efaa8

File tree

2 files changed

2 files changed

`‎commitizen/commands/bump.py‎`

`‎commitizen/defaults.py‎`

0 commit comments