Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 05c1722

Browse files
bearomorphismLee-W
authored andcommitted
refactor(process_commit_message): better type and early return
1 parent 68c4360 commit 05c1722

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

‎commitizen/changelog.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
import re
3131
from collections import OrderedDict, defaultdict
32-
from collections.abc import Generator, Iterable, Mapping, Sequence
32+
from collections.abc import Generator, Iterable, Mapping, MutableMapping, Sequence
3333
from dataclasses import dataclass
3434
from datetime import date
3535
from typing import TYPE_CHECKING, Any
@@ -167,8 +167,8 @@ def process_commit_message(
167167
hook: MessageBuilderHook | None,
168168
parsed: re.Match[str],
169169
commit: GitCommit,
170-
changes: dict[str | None, list],
171-
change_type_map: dict[str, str] | None = None,
170+
ref_changes: MutableMapping[str | None, list],
171+
change_type_map: Mapping[str, str] | None = None,
172172
) -> None:
173173
message: dict[str, Any] = {
174174
"sha1": commit.rev,
@@ -178,13 +178,16 @@ def process_commit_message(
178178
**parsed.groupdict(),
179179
}
180180

181-
if processed := hook(message, commit) if hook else message:
182-
messages = [processed] if isinstance(processed, dict) else processed
183-
for msg in messages:
184-
change_type = msg.pop("change_type", None)
185-
if change_type_map:
186-
change_type = change_type_map.get(change_type, change_type)
187-
changes[change_type].append(msg)
181+
processed_msg = hook(message, commit) if hook else message
182+
if not processed_msg:
183+
return
184+
185+
messages = [processed_msg] if isinstance(processed_msg, dict) else processed_msg
186+
for msg in messages:
187+
change_type = msg.pop("change_type", None)
188+
if change_type_map:
189+
change_type = change_type_map.get(change_type, change_type)
190+
ref_changes[change_type].append(msg)
188191

189192

190193
def generate_ordered_changelog_tree(

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /