Commit 008a8c6

authored

Merge pull request #166 from vBLFTePebWNi6c/fix_git_commit_message

fix(git): fix returned value for GitCommit.message when body is empty

2 parents 985f391 + f21693e commit 008a8c6Copy full SHA for 008a8c6

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ def __init__(self, rev, title, body=""):`
`21`	`21`
`22`	`22`	`@property`
`23`	`23`	`def message(self):`
`24`		`- return f"{self.title}\n\n{self.body}"`
	`24`	`+ return f"{self.title}\n\n{self.body}".strip()`
`25`	`25`
`26`	`26`	`def __repr__(self):`
`27`	`27`	`return f"{self.title} ({self.rev})"`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,3 +47,10 @@ def test_get_tag_names(mocker):`
`47`	`47`	`"commitizen.cmd.run", return_value=FakeCommand(out="", err="No tag available")`
`48`	`48`	`)`
`49`	`49`	`assert git.get_tag_names() == []`
	`50`	`+`
	`51`	`+`
	`52`	`+def test_git_message_with_empty_body():`
	`53`	`+ commit_title = "Some Title"`
	`54`	`+ commit = git.GitCommit("test_rev", "Some Title", body="")`
	`55`	`+`
	`56`	`+ assert commit.message == commit_title`

Comments

(0)