Commit 441e59f

committed

feat: use docker entrypoint

fixes issue #12 BREAKING CHANGE: wrapping script are simplified but not compatible with previous version

1 parent cc9bac2 commit 441e59fCopy full SHA for 441e59f

File tree

+13

-5

lines changed

+13

-5

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,6 @@ RUN ["pip", "install", "-U", "--no-cache-dir", "pip"]`
`9`	`9`	`ARG CZ_VERSION=2.28.0`
`10`	`10`	`RUN pip install --no-cache-dir commitizen==$CZ_VERSION`
`11`	`11`
`12`		`-CMD [ "cz", "version" ]`
	`12`	`+ENTRYPOINT ["cz"]`
	`13`	`+`
	`14`	`+CMD [ "version" ]`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,10 @@ This repo checks daily for the latest version and tries to publish it.`
`25`	`25`	`## As Script`
`26`	`26`
`27`	`27`	```bash
`28`		`-docker run --rm -v $(pwd):/app commitizen/commitizen:latest /bin/sh -c 'cz bump --changelog'`
	`28`	`+docker run --rm \`
	`29`	`+ -v $(pwd):/app \`
	`30`	`+ commitizen/commitizen:latest \`
	`31`	`+ bump --changelog`
`29`	`32`	```
`30`	`33`
`31`	`34`	`## Inside container`
@@ -34,7 +37,10 @@ Open a terminal inside docker with `cz` available and with the current directory
`34`	`37`	This way we can run any `cz` command.
`35`	`38`
`36`	`39`	```bash
`37`		`-docker run --rm -it -v $(pwd):/app commitizen/commitizen:latest`
	`40`	`+docker run --rm -it \`
	`41`	`+ --entrypoint /bin/sh \`
	`42`	`+ -v $(pwd):/app \`
	`43`	`+ commitizen/commitizen:latest`
`38`	`44`	```
`39`	`45`
`40`	`46`	`## Contributing`
`@@ -50,5 +56,5 @@ docker run --rm -it -v $(pwd):/app commitizen/commitizen:latest`
`50`	`56`
`51`	`57`	```bash
`52`	`58`	`./scripts/build`
`53`		`-./scripts/run 'cz ls'`
	`59`	`+./scripts/cz ls`
`54`	`60`	```

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`#!/bin/sh -ex`
`2`		`-docker run --rm --name commitizen registry.hub.docker.com/commitizen/commitizen:3 /bin/sh -c "$@"`
	`2`	`+docker run --rm --name commitizen registry.hub.docker.com/commitizen/commitizen:3 "$@"`

Comments

(0)