Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 833612c

Browse files
feat: #13 change function name and test
1 parent d556035 commit 833612c

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed

‎src/ProjectSetting.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ public function getIssueTypes(array $data)
1515
return $response['IssueTypes'];
1616
}
1717

18-
public function getIssueStatus(array $data)
18+
public function getIssueStatuses(array $data)
1919
{
2020
$this->validate($data, [
2121
'ProjectName' => 'string|required',
2222
'IssueType' => [
23-
'required',
23+
'required_without:IssueTypeId',
2424
Rule::in(Issue::TYPE),
2525
],
2626
'IssueTypeId' => 'nullable|integer',
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?php
2+
3+
namespace Tests\Acceptance;
4+
5+
use Coding\Core;
6+
use Coding\ProjectSetting;
7+
8+
class ProjectSettingTest extends TestCase
9+
{
10+
public function testGetIssueStatuses()
11+
{
12+
$projectSetting = new ProjectSetting($this->token);
13+
$result = $projectSetting->getIssueStatuses([
14+
'ProjectName' => $this->projectName,
15+
'IssueType' => 'DEFECT',
16+
]);
17+
$this->assertEquals('DEFECT', $result[0]['IssueType']);
18+
}
19+
}

‎tests/Unit/ProjectSettingTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function testGetIssueTypes()
2727
$this->assertEquals($response['IssueTypes'], $result);
2828
}
2929

30-
public function testGetIssueStatus()
30+
public function testGetIssueStatuses()
3131
{
3232
$response = json_decode(
3333
file_get_contents($this->dataPath('DescribeProjectIssueStatusListResponse.json')),
@@ -44,7 +44,7 @@ public function testGetIssueStatus()
4444
])->andReturn($response);
4545

4646
$projectSetting = new ProjectSetting($this->token, $this->coreMock);
47-
$result = $projectSetting->getIssueStatus($data);
47+
$result = $projectSetting->getIssueStatuses($data);
4848
$this->assertEquals($response['ProjectIssueStatusList'], $result);
4949
}
5050
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /