Commit 53954cf

committed

feat: #72 error when issue type not exists

1 parent 5bc4e6e commit 53954cfCopy full SHA for 53954cf

File tree

+16

-1

lines changed

+16

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`use App\Coding\Issue;`
`6`	`6`	`use App\Coding\Iteration;`
`7`	`7`	`use App\Coding\Project;`
	`8`	`+use Exception;`
`8`	`9`	`use LaravelZero\Framework\Commands\Command;`
`9`	`10`	`use Rap2hpoutre\FastExcel\Facades\FastExcel;`
`10`	`11`
`@@ -57,7 +58,7 @@ public function handle(Issue $codingIssue, Project $codingProject, Iteration $it`
`57`	`58`	`foreach ($rows as $row) {`
`58`	`59`	`try {`
`59`	`60`	`$issueResult = $this->createIssueByRow($codingProject, $codingIssue, $iteration, $row);`
`60`		`- } catch (\Exception $e) {`
	`61`	`+ } catch (Exception $e) {`
`61`	`62`	`$this->error('Error: ' . $e->getMessage());`
`62`	`63`	`return 1;`
`63`	`64`	`}`
`@@ -77,6 +78,9 @@ private function createIssueByRow(Project $codingProject, Issue $issue, Iteratio`
`77`	`78`	`$this->issueTypes[$item['Name']] = $item;`
`78`	`79`	`}`
`79`	`80`	`}`
	`81`	`+ if (!isset($this->issueTypes[$row['事项类型']])) {`
	`82`	`+ throw new Exception('「' . $row['事项类型'] . '」类型不存在,请在项目设置中添加');`
	`83`	`+ }`
`80`	`84`	`$data = [`
`81`	`85`	`'Type' => $this->issueTypes[$row['事项类型']]['IssueType'],`
`82`	`86`	`'IssueTypeId' => $this->issueTypes[$row['事项类型']]['Id'],`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -178,4 +178,15 @@ public function testImportSubTask()`
`178`	`178`	`->expectsOutput("https://$this->teamDomain.coding.net/p/$this->projectUri/all/issues/" . $subTask2['Code'])`
`179`	`179`	`->assertExitCode(0);`
`180`	`180`	`}`
	`181`	`+`
	`182`	`+ public function testImportFailedIssueTypeNotExists()`
	`183`	`+ {`
	`184`	`+ $mock = \Mockery::mock(Project::class, [])->makePartial();`
	`185`	`+ $this->instance(Project::class, $mock);`
	`186`	`+ $mock->shouldReceive('getIssueTypes')->times(1)->andReturn([]);`
	`187`	`+`
	`188`	`+ $this->artisan('issue:import', ['file' => $this->dataDir . 'coding/scrum-issues.csv'])`
	`189`	`+ ->expectsOutput('Error: 「史诗」类型不存在,请在项目设置中添加')`
	`190`	`+ ->assertExitCode(1);`
	`191`	`+ }`
`181`	`192`	`}`

Comments

(0)