Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 27bf9be

Browse files
refactor: #72 rename to project setting
1 parent 19d210d commit 27bf9be

File tree

6 files changed

+25
-25
lines changed

6 files changed

+25
-25
lines changed

‎app/Coding/Project.php renamed to ‎app/Coding/ProjectSetting.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace App\Coding;
44

5-
class Project extends Base
5+
class ProjectSetting extends Base
66
{
77
public function getIssueTypes($token, $projectName)
88
{

‎app/Commands/IssueImportCommand.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use App\Coding\Issue;
66
use App\Coding\Iteration;
7-
use App\Coding\Project;
7+
use App\Coding\ProjectSetting;
88
use Exception;
99
use LaravelZero\Framework\Commands\Command;
1010
use Rap2hpoutre\FastExcel\Facades\FastExcel;
@@ -41,7 +41,7 @@ class IssueImportCommand extends Command
4141
* Execute the console command.
4242
*
4343
*/
44-
public function handle(Issue $codingIssue, Project$codingProject, Iteration $iteration): int
44+
public function handle(Issue $codingIssue, ProjectSetting$projectSetting, Iteration $iteration): int
4545
{
4646
$this->setCodingApi();
4747

@@ -57,7 +57,7 @@ public function handle(Issue $codingIssue, Project $codingProject, Iteration $it
5757
}
5858
foreach ($rows as $row) {
5959
try {
60-
$issueResult = $this->createIssueByRow($codingProject, $codingIssue, $iteration, $row);
60+
$issueResult = $this->createIssueByRow($projectSetting, $codingIssue, $iteration, $row);
6161
} catch (Exception $e) {
6262
$this->error('Error: ' . $e->getMessage());
6363
return 1;
@@ -70,10 +70,10 @@ public function handle(Issue $codingIssue, Project $codingProject, Iteration $it
7070
return 0;
7171
}
7272

73-
private function getIssueTypes(Project$codingProject, $row): void
73+
private function getIssueTypes(ProjectSetting$projectSetting, array $row): void
7474
{
7575
if (empty($this->issueTypes)) {
76-
$result = $codingProject->getIssueTypes($this->codingToken, $this->codingProjectUri);
76+
$result = $projectSetting->getIssueTypes($this->codingToken, $this->codingProjectUri);
7777
foreach ($result as $item) {
7878
$this->issueTypes[$item['Name']] = $item;
7979
}
@@ -83,9 +83,9 @@ private function getIssueTypes(Project $codingProject, $row): void
8383
}
8484
}
8585

86-
private function createIssueByRow(Project$codingProject, Issue $issue, Iteration $iteration, array $row)
86+
private function createIssueByRow(ProjectSetting$projectSetting, Issue $issue, Iteration $iteration, array $row)
8787
{
88-
$this->getIssueTypes($codingProject, $row);
88+
$this->getIssueTypes($projectSetting, $row);
8989
$data = [
9090
'Type' => $this->issueTypes[$row['事项类型']]['IssueType'],
9191
'IssueTypeId' => $this->issueTypes[$row['事项类型']]['Id'],

‎app/Commands/ProjectGetIssueTypesCommand.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace App\Commands;
44

55
use App\Coding\Issue;
6-
use App\Coding\Project;
6+
use App\Coding\ProjectSetting;
77
use LaravelZero\Framework\Commands\Command;
88

99
class ProjectGetIssueTypesCommand extends Command
@@ -32,11 +32,11 @@ class ProjectGetIssueTypesCommand extends Command
3232
* Execute the console command.
3333
*
3434
*/
35-
public function handle(Project$codingProject): int
35+
public function handle(ProjectSetting$projectSetting): int
3636
{
3737
$this->setCodingApi();
3838

39-
$result = $codingProject->getIssueTypes($this->codingToken, $this->codingProjectUri);
39+
$result = $projectSetting->getIssueTypes($this->codingToken, $this->codingProjectUri);
4040

4141
foreach ($result as $item) {
4242
$this->info($item['Id'] . '' . $item['Name']);

‎tests/Feature/IssueImportCommandTest.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use App\Coding\Issue;
66
use App\Coding\Iteration;
7-
use App\Coding\Project;
7+
use App\Coding\ProjectSetting;
88
use Tests\TestCase;
99

1010
class IssueImportCommandTest extends TestCase
@@ -26,8 +26,8 @@ protected function setUp(): void
2626

2727
public function testImportSuccess()
2828
{
29-
$mock = \Mockery::mock(Project::class, [])->makePartial();
30-
$this->instance(Project::class, $mock);
29+
$mock = \Mockery::mock(ProjectSetting::class, [])->makePartial();
30+
$this->instance(ProjectSetting::class, $mock);
3131

3232
$mock->shouldReceive('getIssueTypes')->times(1)->andReturn(json_decode(
3333
file_get_contents($this->dataDir . 'coding/' . 'DescribeProjectIssueTypeListResponse.json'),
@@ -66,8 +66,8 @@ public function testImportSuccess()
6666

6767
public function testImportUserStorySuccess()
6868
{
69-
$mock = \Mockery::mock(Project::class, [])->makePartial();
70-
$this->instance(Project::class, $mock);
69+
$mock = \Mockery::mock(ProjectSetting::class, [])->makePartial();
70+
$this->instance(ProjectSetting::class, $mock);
7171

7272
$mock->shouldReceive('getIssueTypes')->times(1)->andReturn(json_decode(
7373
file_get_contents($this->dataDir . 'coding/' . 'DescribeProjectIssueTypeListResponse.json'),
@@ -113,8 +113,8 @@ public function testImportUserStorySuccess()
113113

114114
public function testImportSubTask()
115115
{
116-
$mock = \Mockery::mock(Project::class, [])->makePartial();
117-
$this->instance(Project::class, $mock);
116+
$mock = \Mockery::mock(ProjectSetting::class, [])->makePartial();
117+
$this->instance(ProjectSetting::class, $mock);
118118

119119
$mock->shouldReceive('getIssueTypes')->times(1)->andReturn(json_decode(
120120
file_get_contents($this->dataDir . 'coding/' . 'DescribeProjectIssueTypeListResponse.json'),
@@ -179,8 +179,8 @@ public function testImportSubTask()
179179

180180
public function testImportFailedIssueTypeNotExists()
181181
{
182-
$mock = \Mockery::mock(Project::class, [])->makePartial();
183-
$this->instance(Project::class, $mock);
182+
$mock = \Mockery::mock(ProjectSetting::class, [])->makePartial();
183+
$this->instance(ProjectSetting::class, $mock);
184184
$mock->shouldReceive('getIssueTypes')->times(1)->andReturn([]);
185185

186186
$this->artisan('issue:import', ['file' => $this->dataDir . 'coding/scrum-issues.csv'])

‎tests/Feature/ProjectGetIssueTypesCommandTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace Tests\Feature;
44

5-
use App\Coding\Project;
5+
use App\Coding\ProjectSetting;
66
use Tests\TestCase;
77

88
class ProjectGetIssueTypesCommandTest extends TestCase
@@ -20,8 +20,8 @@ protected function setUp(): void
2020

2121
public function testCreateSuccess()
2222
{
23-
$mock = \Mockery::mock(Project::class, [])->makePartial();
24-
$this->instance(Project::class, $mock);
23+
$mock = \Mockery::mock(ProjectSetting::class, [])->makePartial();
24+
$this->instance(ProjectSetting::class, $mock);
2525

2626
$mock->shouldReceive('getIssueTypes')->times(1)->andReturn(json_decode(
2727
file_get_contents($this->dataDir . 'coding/' . 'DescribeProjectIssueTypeListResponse.json'),

‎tests/Unit/CodingProjectTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace Tests\Unit;
44

5-
use App\Coding\Project;
5+
use App\Coding\ProjectSetting;
66
use GuzzleHttp\Client;
77
use GuzzleHttp\Psr7\Response;
88
use Tests\TestCase;
@@ -34,7 +34,7 @@ public function testCreateSuccess()
3434
]
3535
)
3636
->willReturn(new Response(200, [], $responseBody));
37-
$coding = new Project($clientMock);
37+
$coding = new ProjectSetting($clientMock);
3838
$result = $coding->getIssueTypes($codingToken, $codingProjectUri);
3939
$this->assertEquals(json_decode($responseBody, true)['Response']['IssueTypes'], $result);
4040
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /