Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Keep timestamps off the stack #41

Open

Description

(I am not sure why this this wasn't raised as an issue, and have just remembered it now, so moving it to a more appropriate place).
Currently, both it#{ and describe#{ leave a timestamp on the stack, used for reporting the runtime of the users code. This is essentially an implementation detail, but the issue is that it can interfere with user code. Consider this:

"tests" describe#{
 <some-large-data-structure>
 "should work in context A" it#{
 dup run-test-a
 }#
 
 "should work in context B" it#{
 dup run-test-b
 }#
 drop
}#

This seems fairly regular code, however without the author realising it, it will be calling both run-test words with some arbitrary number, instead of the expected data structure!

There is really no reason for the timestamps to be left on the stack like this, and it is simple to fix. Simply scan the relevant block, and run the resulting quotation inside dip such that the timestamp is moved to the retain stack. See this for a simple proof of concept.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /