Commit 217afe2

committed

simplify: use direct node.children check instead of has_children() method

Even simpler approach: - Replace node.has_children() with direct if node.children: - Remove unnecessary has_children() methods from all classes - Pythonic and direct - empty lists are falsy, non-empty are truthy - Less code, same functionality This is the most straightforward way to check for children in Python.

1 parent 5efe631 commit 217afe2Copy full SHA for 217afe2

File tree

2 files changed

-7

lines changed

src/gitingest
- output_formatter.py
- schemas
  - filesystem.py

2 files changed

-7

lines changed

`‎src/gitingest/output_formatter.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ def _create_tree_structure(`
`156`	`156`	`display_name = node.get_display_name()`
`157`	`157`	`tree_str += f"{prefix}{current_prefix}{display_name}\n"`
`158`	`158`
`159`		`- if node.has_children():`
	`159`	`+ if node.children:`
`160`	`160`	`prefix += " " if is_last else "│ "`
`161`	`161`	`for i, child in enumerate(node.children):`
`162`	`162`	`tree_str += _create_tree_structure(query, node=child, prefix=prefix, is_last=i == len(node.children) - 1)`

`‎src/gitingest/schemas/filesystem.py`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -112,9 +112,7 @@ def get_display_name(self) -> str:`
`112`	`112`	`"""Get display name for tree view. Override in subclasses."""`
`113`	`113`	`return self.name`
`114`	`114`
`115`		`- def has_children(self) -> bool:`
`116`		`- """Return whether this node has children to display."""`
`117`		`- return False`
	`115`	`+`
`118`	`116`
`119`	`117`	`@property`
`120`	`118`	`def content(self) -> str:`
`@@ -167,9 +165,7 @@ def get_display_name(self) -> str:`
`167`	`165`	`"""Directories get a trailing slash."""`
`168`	`166`	`return self.name + "/"`
`169`	`167`
`170`		`- def has_children(self) -> bool:`
`171`		`- """Directories have children if the list is not empty."""`
`172`		`- return bool(self.children)`
	`168`	`+`
`173`	`169`
`174`	`170`	`def render_tree(self, prefix: str = "", *, is_last: bool = True) -> list[str]:`
`175`	`171`	`"""Render the tree representation of this directory."""`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 217afe2

File tree

2 files changed

2 files changed

`‎src/gitingest/output_formatter.py`

`‎src/gitingest/schemas/filesystem.py`

0 commit comments