Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit a650eb1

Browse files
kroumaMatyáš KroupaMrRefactoring
authored
Swap form-data for formdata-node (MrRefactoring#333)
The newer library better supports modules and is written in TypeScript. The FormData interface is a drop-in replacement except for getHeaders(), but that didn't do anything useful, so it can be dropped. Closes MrRefactoring#327 Signed-off-by: Matyáš Kroupa <m.kroupa@quadient.com> Co-authored-by: Matyáš Kroupa <m.kroupa@quadient.com> Co-authored-by: Vladislav Tupikin <MrRefactoring@yandex.ru>
1 parent df8e9d2 commit a650eb1

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

‎package-lock.json‎

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@
7171
"vitest": "^2.1.8"
7272
},
7373
"dependencies": {
74-
"axios": "^1.7.9",
75-
"form-data": "^4.0.1",
76-
"tslib": "^2.8.1"
74+
"axios": "^1.7.7",
75+
"formdata-node": "^6.0.3",
76+
"tslib": "^2.7.0"
7777
}
7878
}

‎src/serviceDesk/serviceDesk.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import *asFormData from 'form-data';
1+
import {FormData }from 'formdata-node';
22
import * as Models from './models';
33
import * as Parameters from './parameters';
44
import { Callback } from '../callback';
@@ -124,7 +124,6 @@ export class ServiceDesk {
124124
headers: {
125125
'X-Atlassian-Token': 'no-check',
126126
'Content-Type': 'multipart/form-data',
127-
...formData.getHeaders?.(),
128127
},
129128
data: formData,
130129
};

‎src/version2/issueAttachments.ts‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// @ts-expect-error Wrong form data typings
2-
import FormData from 'form-data';
1+
import { FormData } from 'formdata-node';
32
import * as Models from './models';
43
import * as Parameters from './parameters';
54
import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
434433
headers: {
435434
'X-Atlassian-Token': 'no-check',
436435
'Content-Type': 'multipart/form-data',
437-
...formData.getHeaders?.(),
438436
},
439437
data: formData,
440438
maxBodyLength: Infinity,

‎src/version3/issueAttachments.ts‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// @ts-expect-error Wrong form data typings
2-
import FormData from 'form-data';
1+
import { FormData } from 'formdata-node';
32
import * as Models from './models';
43
import * as Parameters from './parameters';
54
import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
434433
headers: {
435434
'X-Atlassian-Token': 'no-check',
436435
'Content-Type': 'multipart/form-data',
437-
...formData.getHeaders?.(),
438436
},
439437
data: formData,
440438
maxBodyLength: Infinity,

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /