Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 294ac3b

Browse files
fix: avoid referencing loki subchart when disabled (#60)
1 parent 54cc333 commit 294ac3b

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Logs will be scraped from all pods in the Kubernetes cluster.
2222

2323
```bash
2424
helm repo add coder-observability https://helm.coder.com/observability
25-
helm upgrade --install coder-observability coder-observability/coder-observability --version 0.4.0 --namespace coder-observability --create-namespace
25+
helm upgrade --install coder-observability coder-observability/coder-observability --version 0.4.1 --namespace coder-observability --create-namespace
2626
```
2727

2828
## Requirements

‎coder-observability/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: coder-observability
33
description: Gain insights into your Coder deployment
44
type: application
5-
version: 0.4.0
5+
version: 0.4.1
66
dependencies:
77
- name: pyroscope
88
condition: pyroscope.enabled

‎coder-observability/templates/_collector-config.tpl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,13 @@ loki.process "pod_logs" {
197197
{{ if $agent.extraBlocks -}}
198198
{{ $agent.extraBlocks }}
199199
{{- end }}
200+
{{ if .Values.loki.enabled -}}
200201
loki.write "loki" {
201202
endpoint {
202203
url = "http://{{ include "loki.fullname" .Subcharts.loki }}-gateway.{{ .Release.Namespace }}.{{ .Values.global.zone }}/loki/api/v1/push"
203204
}
204205
}
206+
{{- end }}
205207

206208
{{ if .Values.pyroscope.enabled }}
207209
pyroscope.scrape "pods" {
@@ -407,4 +409,4 @@ prometheus.scrape "coder_metrics" {
407409
{{- range $key, $val := . -}}
408410
{{ $key }} = "{{ $val }}",
409411
{{- end -}}
410-
{{ end }}
412+
{{ end }}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /