Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

wrong error message in LinkHandler.kt verifyDownloadLink() #551

Open
Labels
@nils-dehn

Description

The logic the defines the error message logic is inverted.
If allowlisted is false (= not allowlisted) but https is true it will show the "not using HTTPS" error message
If https is false (= not using https) but allowlisted=true it will show the "not-allowlisted" error message

 if (allowlisted) {
 "The download link is from a non-allowlisted URL"
 } else if (https) {
 "The download link is not using HTTPS"
 } else {
 "The download link is from a non-allowlisted URL and is not using HTTPS"
 }

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /