Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Bug]: PWA icons do not load on iOS/iPadOS #4994

Closed
Assignees
Labels
bugSomething isn't working os-iosiOS/iPad related
Milestone
@umdstu

Description

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Safari
  • Local OS: iOS/iPadOS
  • Remote OS: raspberryPi OS
  • Remote Architecture: armv7l
  • code-server --version: 4.1.0 9e620e9 with Code 1.63.0

Steps to Reproduce

  1. Open code-server on an iPad or iPhone
  2. Add Shortcut to Homescreen (save as PWA)

Expected

The PWA icon should be rendered as the icon when saved to the homescreen on an iPad or iPhone.

Actual

A screen grab is the icon image instead of the PWA icon

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

The issue appears to be due to permissions of certain directories. If you access code-server without being logged in, and attempt to bookmark the page, you get the correct icon, which fetches and renders https://chases.io/_static/src/browser/media/pwa-icon-512.png . However, once you're logged in, the icon it tries to fetch is https://chases.io/static/resources/server/pwa-icon-512.png . Safari seems to attempt to fetch the icon unauthenticated, so it gets a 401 for that file. I manually replaced the path being used when authenticated (for the latter icon) in workbench.html with the path being used in login.html (the former path), and it loaded just fine.

I believe that the only solution is to ensure the PWA icon path, regardless of the .html file used, is accessible when unauthenticated. This applies to both the path of the file, the path in the manifest.json, and anywhere else, e.g. remoteExtensionHostAgent.js.

Metadata

Metadata

Labels

bugSomething isn't working os-iosiOS/iPad related

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    AltStyle によって変換されたページ (->オリジナル) /