Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

without-browser-env-var variable is not sent to vscode server #4721

Closed
Assignees
Labels
bugSomething isn't working
Milestone
@migolo

Description

without-browser-env-var is not specified, so tools like create-react-app attempts to start a browser at the vscode defined path and crashes

Sorry for the incomplete data, I will try to edit the issue with the logs and paths appended later

OS/Web Information

  • Web Browser: Any (Chrome)
  • Local OS: Mac OSX
  • Remote OS: Ubuntu
  • Remote Architecture: amd64
  • code-server --version: 4.0.1

Steps to Reproduce

  1. Run npm start on integrated terminal for code-server
  2. Crashes immediately trying to look at browser.sh from vscode

Expected

npm start should start, not crash.

Actual

Crashes

Notes

This is the line that gets appended to the browser env so react crashes (as there should not be a browser env file) https://github.com/microsoft/vscode/blob/6249dab4fe849d0ad11500fabd28ddc204ef12da/src/vs/server/extensionHostConnection.ts#L60

code-server version 3.12.0 doesn't crash

This issue can be reproduced in VS Code: No

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    AltStyle によって変換されたページ (->オリジナル) /