-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Switching to Fastify #2931
-
Currently, code-server uses Express.JS, which is quite slow and bloated. This is bad because users on lower-end WiFi would have to load code-server really slowly. For example, I am stuck to using a mobile hotspot in school, due to the school WiFi using a whitelist system
Fastify is much quicker than Express by a large amount and the benchmark shows it: https://www.fastify.io/benchmarks/
I was wondering if anyone was interested in switching, or if I would be wasting my time if I were to make a Pull Request attempting this myself.
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
This is the first time I've heard of Fastify but it looks promising. And better performance would be nice.
@code-asher would love to get your thoughts on this?
Replies: 1 comment 3 replies
-
This is the first time I've heard of Fastify but it looks promising. And better performance would be nice.
@code-asher would love to get your thoughts on this?
Beta Was this translation helpful? Give feedback.
All reactions
-
Sounds interesting, but requests/sec is most likely/almost definitely not the speedbump they're hitting - they mentioned low-end WiFi/mobile hotspots, which indicates that there's more of a bandwidth/latency issue.
I don't think it would help out in a meaningful enough way in that scenario, or for our usecase in general - code-server is a mostly single-user application so reqs/second isn't something we need to optimize for, imo.
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 2
-
Upgrading to a newer JS framework would'nt be tiresome? @jsjoeio
I know frameworks can be nice, but adapting them is difficult. See, Angular for example, it grew like fire and now, nobody touches it.
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 2
-
Yeah, agreed. I think @oxy made solid points. Probably wouldn't make sense for us to change.
Beta Was this translation helpful? Give feedback.