Commit f5cf3fd

committed

proxy.ts: Do not always rewrite redirects against the base path

This breaks --proxy-path-passthrough However, we still need this when that code is disabled as many apps will issue absolute redirects and expect the proxy to rewrite as appropriate. e.g. Go's http.Redirect will rewrite relative redirects as absolute! See https://golang.org/pkg/net/http/#Redirect

1 parent 5446e0a commit f5cf3fdCopy full SHA for f5cf3fd

File tree

2 files changed

-2

lines changed

src/node
- proxy.ts
- routes
  - pathProxy.ts

2 files changed

-2

lines changed

`‎src/node/proxy.ts‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,8 @@ proxy.on("error", (error, _, res) => {`
`9`	`9`	`})`
`10`	`10`
`11`	`11`	`// Intercept the response to rewrite absolute redirects against the base path.`
	`12`	`+// Is disabled when the request has no base path which means --proxy-path-passthrough has`
	`13`	`+// been enabled.`
`12`	`14`	`proxy.on("proxyRes", (res, req) => {`
`13`	`15`	`if (res.headers.location && res.headers.location.startsWith("/") && (req as any).base) {`
`14`	`16`	`res.headers.location = (req as any).base + res.headers.location`

`‎src/node/routes/pathProxy.ts‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,10 @@ router.all("/(:port)(/*)?", (req, res) => {`
`28`	`28`	`throw new HttpError("Unauthorized", HttpCode.Unauthorized)`
`29`	`29`	`}`
`30`	`30`
`31`		`- // Absolute redirects need to be based on the subpath when rewriting.`
`32`		- ;(req as any).base = `${req.baseUrl}/${req.params.port}`
	`31`	`+ if (!req.args["proxy-path-passthrough"]) {`
	`32`	`+ // Absolute redirects need to be based on the subpath when rewriting.`
	`33`	+ ;(req as any).base = `${req.baseUrl}/${req.params.port}`
	`34`	`+ }`
`33`	`35`
`34`	`36`	`proxy.web(req, res, {`
`35`	`37`	`ignorePath: true,`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit f5cf3fd

File tree

2 files changed

2 files changed

`‎src/node/proxy.ts‎`

`‎src/node/routes/pathProxy.ts‎`

0 commit comments