Commit bd43ca4

committed

helm: Fix README examples

Not sure where --name came from? Maybe an older version of helm. Ah, it's from v2.16.7

1 parent 52ea32f commit bd43ca4Copy full SHA for bd43ca4

File tree

2 files changed

+12

-11

lines changed

ci/helm-chart
- README.md
- values.yaml

2 files changed

+12

-11

lines changed

`‎ci/helm-chart/README.md‎`

Lines changed: 11 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt`
`10`	`10`	`## TL;DR;`
`11`	`11`
`12`	`12`	```console
`13`		`-$ git clone https://github.com/cdr/code-server.git`
`14`		`-$ helm install code-server charts/code-server`
	`13`	`+$ git clone https://github.com/cdr/code-server`
	`14`	`+$ helm install code-server code-server/ci/helm-chart`
`15`	`15`	```
`16`	`16`
`17`	`17`	`## Introduction`
`@@ -26,10 +26,11 @@ package manager.`
`26`	`26`
`27`	`27`	`## Installing the Chart`
`28`	`28`
`29`		-To install the chart with the release name `my-release`:
	`29`	+To install the chart with the release name `code-server`:
`30`	`30`
`31`	`31`	```console
`32`		`-$ helm install --name my-release charts/code-server`
	`32`	`+$ git clone https://github.com/cdr/code-server`
	`33`	`+$ helm install code-server code-server/ci/helm-chart`
`33`	`34`	```
`34`	`35`
`35`	`36`	`The command deploys code-server on the Kubernetes cluster in the default`
`@@ -40,10 +41,10 @@ that can be configured during installation.`
`40`	`41`
`41`	`42`	`## Uninstalling the Chart`
`42`	`43`
`43`		-To uninstall/delete the `my-release` deployment:
	`44`	+To uninstall/delete the `code-server` deployment:
`44`	`45`
`45`	`46`	```console
`46`		`-$ helm delete my-release`
	`47`	`+$ helm delete code-server`
`47`	`48`	```
`48`	`49`
`49`	`50`	`The command removes all the Kubernetes components associated with the chart and`
@@ -97,9 +98,9 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
`97`	`98`	install`. For example,
`98`	`99`
`99`	`100`	```console
`100`		`-$ helm install --name my-release \`
`101`		`- --set persistence.enabled=false \`
`102`		`- deployment/chart`
	`101`	`+$ helm install code-server \`
	`102`	`+ deployment/chart \`
	`103`	`+ --set persistence.enabled=false`
`103`	`104`	```
`104`	`105`
`105`	`106`	`The above command sets the the persistence storage to false.`
`@@ -108,7 +109,7 @@ Alternatively, a YAML file that specifies the values for the above parameters`
`108`	`109`	`can be provided while installing the chart. For example,`
`109`	`110`
`110`	`111`	```console
`111`		`-$ helm install --name my-release -f values.yaml deployment/chart`
	`112`	`+$ helm install code-server deployment/chart -f values.yaml`
`112`	`113`	```
`113`	`114`
`114`	`115`	`> Tip: You can use the default [values.yaml](values.yaml)`

`‎ci/helm-chart/values.yaml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ persistence:`
`112`	`112`	`##`
`113`	`113`	`# storageClass: "-"`
`114`	`114`	`accessMode: ReadWriteOnce`
`115`		`- size: 1Gi`
	`115`	`+ size: 10Gi`
`116`	`116`	`annotations: {}`
`117`	`117`	`# existingClaim: ""`
`118`	`118`	`# hostPath: /data`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit bd43ca4

File tree

2 files changed

2 files changed

`‎ci/helm-chart/README.md‎`

`‎ci/helm-chart/values.yaml‎`

0 commit comments