Commit 63e9ebd

authored

fix: setting created_at field in Model::replace() method (#9693)

1 parent af194bf commit 63e9ebdCopy full SHA for 63e9ebd

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1220,7 +1220,9 @@ public function replace(?array $row = null, bool $returnSQL = false)`
`1220`	`1220`	`return false;`
`1221`	`1221`	`}`
`1222`	`1222`
`1223`		`- $row = $this->setUpdatedField((array) $row, $this->setDate());`
	`1223`	`+ $row = (array) $row;`
	`1224`	`+ $row = $this->setCreatedField($row, $this->setDate());`
	`1225`	`+ $row = $this->setUpdatedField($row, $this->setDate());`
`1224`	`1226`
`1225`	`1227`	`return $this->doReplace($row, $returnSQL);`
`1226`	`1228`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,13 @@ public function testReplaceRespectsUseTimestamps(): void`
`38`	`38`	`$data['country'] = 'UK';`
`39`	`39`
`40`	`40`	`$sql = $this->model->replace($data, true);`
	`41`	`+ $this->assertStringNotContainsString('created_at', (string) $sql);`
`41`	`42`	`$this->assertStringNotContainsString('updated_at', (string) $sql);`
`42`	`43`
`43`	`44`	`$this->model = $this->createModel(UserModel::class);`
`44`	`45`	`$this->setPrivateProperty($this->model, 'useTimestamps', true);`
`45`	`46`	`$sql = $this->model->replace($data, true);`
	`47`	`+ $this->assertStringContainsString('created_at', (string) $sql);`
`46`	`48`	`$this->assertStringContainsString('updated_at', (string) $sql);`
`47`	`49`	`}`
`48`	`50`	`}`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ Bugs Fixed`
`33`	`33`	- Database: Fixed a bug in ``Database::connect()`` which was causing to store non-shared connection instances in shared cache.
`34`	`34`	- Database: Fixed a bug in ``Connection::getFieldData()`` for ``SQLSRV`` and ``OCI8`` where extra characters were returned in column default values (specific to those handlers), instead of following the convention used by other drivers.
`35`	`35`	- Forge: Fixed a bug in ``Postgre`` and ``SQLSRV`` where changing a column's default value using ``Forge::modifyColumn()`` method produced incorrect SQL syntax.
	`36`	+- Model: Fixed a bug in ``Model::replace()`` where ``created_at`` field (when available) wasn't set correctly.
`36`	`37`
`37`	`38`	`See the repo's`
`38`	`39`	`CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_

Comments

(0)