Commit 2300b17

authored

fix: avoid emitting warnings when ruby is run with -w (#1)

I've also turned on warnings for this gem's tests, to make it more obvious when this is happening in the future. Without this fix, users will see repeated messages like this: > source_file_formatter.rb:20: warning: instance variable @line_coverage not initialized

1 parent 76cc7b4 commit 2300b17Copy full SHA for 2300b17

File tree

2 files changed

-1

lines changed

.rspec
lib/simplecov_json_formatter
- source_file_formatter.rb

2 files changed

-1

lines changed

`‎.rspec`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+--warnings`

`‎lib/simplecov_json_formatter/source_file_formatter.rb`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ module SimpleCovJSONFormatter`
`4`	`4`	`class SourceFileFormatter`
`5`	`5`	`def initialize(source_file)`
`6`	`6`	`@source_file = source_file`
	`7`	`+ @line_coverage = nil`
`7`	`8`	`end`
`8`	`9`
`9`	`10`	`def format`
`@@ -17,7 +18,7 @@ def format`
`17`	`18`	`private`
`18`	`19`
`19`	`20`	`def line_coverage`
`20`		`- @line_coverage \|\| {`
	`21`	`+ @line_coverage \|\|= {`
`21`	`22`	`lines: lines`
`22`	`23`	`}`
`23`	`24`	`end`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 2300b17

File tree

2 files changed

2 files changed

`‎.rspec`

`‎lib/simplecov_json_formatter/source_file_formatter.rb`

0 commit comments