Commit 680208d

Samuel-StOCopilot

authored and

committed

fix(playwright): relaunch browser correctly with restart: 'session' in run-workers --by pool (#5118)

* fix: Reset browser context and state on close * test: add acceptance tests

1 parent 4a71c75 commit 680208dCopy full SHA for 680208d

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,9 @@ jobs:`
`48`	`48`	`run: './bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'`
`49`	`49`	`- name: run chromium with restart==browser tests`
`50`	`50`	`run: 'BROWSER_RESTART=browser ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'`
`51`		`- - name: run chromium with restart==session tests`
	`51`	`+ - name: run chromium with restart==session tests on 2 workers split by pool`
	`52`	`+ run: 'BROWSER_RESTART=session ./bin/codecept.js run-workers 2 -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug --by=pool'`
	`53`	`+ - name: run chromium with restart==session tests and`
`52`	`54`	`run: 'BROWSER_RESTART=session ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'`
`53`	`55`	`- name: run firefox tests`
`54`	`56`	`run: 'BROWSER=firefox node ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1031,7 +1031,10 @@ class Playwright extends Helper {`
`1031`	`1031`	`this.frame = null`
`1032`	`1032`	`popupStore.clear()`
`1033`	`1033`	`if (this.options.recordHar) await this.browserContext.close()`
	`1034`	`+ this.browserContext = null`
`1034`	`1035`	`await this.browser.close()`
	`1036`	`+ this.browser = null`
	`1037`	`+ this.isRunning = false`
`1035`	`1038`	`}`
`1036`	`1039`
`1037`	`1040`	`async _evaluateHandeInContext(...args) {`

Comments

(0)