Commit 3f57ed7

committed

Added check when setting serial port parameters

This allows to detect for invalid baud rate settings in particular on Linux where the kernel do not allow non-standard baud rates on some devices. See arduino#3389 See arduino#3351

1 parent c08d4fd commit 3f57ed7Copy full SHA for 3f57ed7

File tree

1 file changed

-1

lines changed

arduino-core/src/processing/app
- Serial.java

1 file changed

-1

lines changed

`‎arduino-core/src/processing/app/Serial.java‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,11 @@ private Serial(String iname, int irate, char iparity, int idatabits, float istop`
`112`	`112`	`try {`
`113`	`113`	`port = new SerialPort(iname);`
`114`	`114`	`port.openPort();`
`115`		`- port.setParams(irate, idatabits, stopbits, parity, true, true);`
	`115`	`+ boolean res = port.setParams(irate, idatabits, stopbits, parity, true, true);`
	`116`	`+ if (!res) {`
	`117`	`+ System.err.println(format(_("Error while setting serial port parameters: {0} {1} {2} {3}"),`
	`118`	`+ irate, iparity, idatabits, istopbits));`
	`119`	`+ }`
`116`	`120`	`port.addEventListener(this);`
`117`	`121`	`} catch (SerialPortException e) {`
`118`	`122`	`if (e.getPortName().startsWith("/dev") && SerialPortException.TYPE_PERMISSION_DENIED.equals(e.getExceptionType())) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3f57ed7

File tree

1 file changed

1 file changed

`‎arduino-core/src/processing/app/Serial.java‎`

0 commit comments