Commit ce4416f

authored

fix: type with empty value should clear the input (testing-library#50)

1 parent ef97beb commit ce4416fCopy full SHA for ce4416f

File tree

+26

-2

lines changed

projects/testing-library
- src/lib/user-events
  - type.ts
- tests/user-events
  - type.spec.ts

+26

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export function createType(fireEvent: FireFunction & FireObject) {`
`40`	`40`	`const { allAtOnce = false, delay = 0 } = options \|\| {};`
`41`	`41`	`const initialValue = (element as HTMLInputElement).value;`
`42`	`42`
`43`		`- if (allAtOnce) {`
	`43`	`+ if (allAtOnce\|\|value==='') {`
`44`	`44`	`fireEvent.input(element, { target: { value } });`
`45`	`45`	`element.addEventListener('blur', createFireChangeEvent(initialValue));`
`46`	`46`	`return;`

Lines changed: 25 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ describe('options', () => {`
`178`	`178`	`});`
`179`	`179`	`});`
`180`	`180`
`181`		`-test('should not type when event.preventDefault() is called', async () => {`
	`181`	`+test('does not type when event.preventDefault() is called', async () => {`
`182`	`182`	`@Component({`
`183`	`183`	`selector: 'fixture',`
`184`	`184`	template: `
`@@ -219,3 +219,27 @@ test('should not type when event.preventDefault() is called', async () => {`
`219`	`219`
`220`	`220`	`expect(inputControl.value).toBe('');`
`221`	`221`	`});`
	`222`	`+`
	`223`	`+test('can clear an input field', async () => {`
	`224`	`+ @Component({`
	`225`	`+ selector: 'fixture',`
	`226`	+ template: `
	`227`	`+ <input type="text" data-testid="input" [value]="initialValue" />`
	`228`	+ `,
	`229`	`+ })`
	`230`	`+ class FixtureComponent {`
	`231`	`+ @Input() initialValue = '';`
	`232`	`+ }`
	`233`	`+`
	`234`	`+ const component = await render(FixtureComponent, {`
	`235`	`+ componentProperties: {`
	`236`	`+ initialValue: 'an initial value',`
	`237`	`+ },`
	`238`	`+ });`
	`239`	`+`
	`240`	`+ const inputControl = component.getByTestId('input') as HTMLInputElement;`
	`241`	`+ expect(inputControl.value).toBe('an initial value');`
	`242`	`+`
	`243`	`+ component.type(inputControl, '');`
	`244`	`+ expect(inputControl.value).toBe('');`
	`245`	`+});`

Comments

(0)