Commit 2b9e6c4

authored

fix: allow component declarations in modules (testing-library#28)

Use the `excludeComponentDeclaration` option to exclude the component to be automatically be added as a declaration.

1 parent c4c6250 commit 2b9e6c4Copy full SHA for 2b9e6c4

File tree

+45

-2

lines changed

+45

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,9 @@ export interface RenderOptions<C, Q extends Queries = typeof queries> {`
`20`	`20`	`componentProviders?: any[];`
`21`	`21`	`queries?: Q;`
`22`	`22`	`wrapper?: Type<any>;`
	`23`	`+ /**`
	`24`	`+ * Exclude the component to be automatically be added as a declaration`
	`25`	`+ * This is needed when the component is declared in an imported module`
	`26`	`+ */`
	`27`	`+ excludeComponentDeclaration?: boolean;`
`23`	`28`	`}`

Lines changed: 19 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,16 @@ export async function render<T>(`
`29`	`29`	`wrapper = WrapperComponent,`
`30`	`30`	`componentProperties = {},`
`31`	`31`	`componentProviders = [],`
	`32`	`+ excludeComponentDeclaration = false,`
`32`	`33`	`} = renderOptions;`
`33`	`34`
`34`	`35`	`const isTemplate = typeof templateOrComponent === 'string';`
`35`		`- const componentDeclarations = isTemplate ? [wrapper] : [templateOrComponent];`
	`36`	`+ const componentDeclarations = declareComponents({`
	`37`	`+ templateOrComponent,`
	`38`	`+ wrapper,`
	`39`	`+ isTemplate,`
	`40`	`+ excludeComponentDeclaration,`
	`41`	`+ });`
`36`	`42`
`37`	`43`	`TestBed.configureTestingModule({`
`38`	`44`	`declarations: [...declarations, ...componentDeclarations],`
`@@ -144,3 +150,15 @@ function setComponentProperties<T>(`
`144`	`150`	`}`
`145`	`151`	`return fixture;`
`146`	`152`	`}`
	`153`	`+`
	`154`	`+function declareComponents({ isTemplate, wrapper, excludeComponentDeclaration, templateOrComponent }) {`
	`155`	`+ if (isTemplate) {`
	`156`	`+ return [wrapper];`
	`157`	`+ }`
	`158`	`+`
	`159`	`+ if (excludeComponentDeclaration) {`
	`160`	`+ return [];`
	`161`	`+ }`
	`162`	`+`
	`163`	`+ return [templateOrComponent];`
	`164`	`+}`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,20 @@`
	`1`	`+import { Component, ElementRef, OnInit, NgModule } from '@angular/core';`
	`2`	`+import { render } from '../src/public_api';`
	`3`	`+`
	`4`	`+@Component({`
	`5`	`+ selector: 'fixture',`
	`6`	+ template: ``,
	`7`	`+})`
	`8`	`+class FixtureComponent {}`
	`9`	`+`
	`10`	`+@NgModule({`
	`11`	`+ declarations: [FixtureComponent],`
	`12`	`+})`
	`13`	`+export class FixtureModule {}`
	`14`	`+`
	`15`	`+test('should not throw if component is declared in an import', async () => {`
	`16`	`+ await render(FixtureComponent, {`
	`17`	`+ imports: [FixtureModule],`
	`18`	`+ excludeComponentDeclaration: true,`
	`19`	`+ });`
	`20`	`+});`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Component, Input,ElementRef, OnInit } from '@angular/core';`
	`1`	`+import { Component, ElementRef, OnInit } from '@angular/core';`
`2`	`2`	`import { render } from '../src/public_api';`
`3`	`3`
`4`	`4`	`@Component({`

Comments

(0)