Commit dcbff06

committed

dmidecode: Clarify error message on table read failure

Stop using the term "unreachable" when the DMI table can't be read. It originates from the /dev/mem access method, but no longer makes sense when reading from sysfs or from a binary dump file. Also don't suggest building with -DUSE_MMAP if reading from sysfs, as it wouldn't help anyway.

1 parent 23aa505 commit dcbff06Copy full SHA for dcbff06

File tree

1 file changed

-3

lines changed

dmidecode.c

1 file changed

-3

lines changed

`‎dmidecode.c‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4550,11 +4550,12 @@ static void dmi_table(off_t base, u32 len, u16 num, u16 ver, const char *devmem,`
`4550`	`4550`
`4551`	`4551`	`if (buf == NULL)`
`4552`	`4552`	`{`
`4553`		`- fprintf(stderr, "Table is unreachable, sorry."`
	`4553`	`+ fprintf(stderr, "Failed to read table, sorry.\n");`
`4554`	`4554`	`#ifndef USE_MMAP`
`4555`		`- " Try compiling dmidecode with -DUSE_MMAP."`
	`4555`	`+ if (!(flags & FLAG_NO_FILE_OFFSET))`
	`4556`	`+ fprintf(stderr,`
	`4557`	`+ "Try compiling dmidecode with -DUSE_MMAP.\n");`
`4556`	`4558`	`#endif`
`4557`		`- "\n");`
`4558`	`4559`	`return;`
`4559`	`4560`	`}`
`4560`	`4561`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit dcbff06

File tree

1 file changed

1 file changed

`‎dmidecode.c‎`

0 commit comments