Commit 310a6e5

committed

code refactor

1 parent 9faafc6 commit 310a6e5Copy full SHA for 310a6e5

File tree

-9

lines changed

-9

lines changed

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,9 @@ public Comment updateComment(@PathVariable (value = "postId") Long postId,`
`53`	`53`	`@DeleteMapping("/posts/{postId}/comments/{commentId}")`
`54`	`54`	`public ResponseEntity<?> deleteComment(@PathVariable (value = "postId") Long postId,`
`55`	`55`	`@PathVariable (value = "commentId") Long commentId) {`
`56`		`- if(!postRepository.existsById(postId)) {`
`57`		`- throw new ResourceNotFoundException("PostId " + postId + " not found");`
`58`		`- }`
`59`		`-`
`60`		`- return commentRepository.findById(commentId).map(comment -> {`
`61`		`- commentRepository.delete(comment);`
`62`		`- return ResponseEntity.ok().build();`
`63`		`- }).orElseThrow(() -> new ResourceNotFoundException("CommentId " + commentId + " not found"));`
	`56`	`+ return commentRepository.findByIdAndPostId(commentId, postId).map(comment -> {`
	`57`	`+ commentRepository.delete(comment);`
	`58`	`+ return ResponseEntity.ok().build();`
	`59`	`+ }).orElseThrow(() -> new ResourceNotFoundException("Comment not found with id " + commentId + " and postId " + postId));`
`64`	`60`	`}`
`65`	`61`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`public class PostController {`
`16`	`16`
`17`	`17`	`@Autowired`
`18`		`- PostRepository postRepository;`
	`18`	`+ privatePostRepository postRepository;`
`19`	`19`
`20`	`20`	`@GetMapping("/posts")`
`21`	`21`	`public Page<Post> getAllPosts(Pageable pageable) {`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,13 @@`
`6`	`6`	`import org.springframework.data.jpa.repository.JpaRepository;`
`7`	`7`	`import org.springframework.stereotype.Repository;`
`8`	`8`
	`9`	`+import java.util.Optional;`
	`10`	`+`
`9`	`11`	`/**`
`10`	`12`	`* Created by rajeevkumarsingh on 21/11/17.`
`11`	`13`	`*/`
`12`	`14`	`@Repository`
`13`	`15`	`public interface CommentRepository extends JpaRepository<Comment, Long> {`
`14`	`16`	`Page<Comment> findByPostId(Long postId, Pageable pageable);`
	`17`	`+ Optional<Comment> findByIdAndPostId(Long id, Long postId);`
`15`	`18`	`}`

Comments

(0)