Commit 5e91617

committed

fix: wait for pool.end()

Because when you don't pass a callback to .end() it always returns a promise

1 parent e81fc3d commit 5e91617Copy full SHA for 5e91617

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -356,16 +356,15 @@ class Pool extends EventEmitter {`
`356`	`356`	`if (isExpired) {`
`357`	`357`	`this.log('remove expired client')`
`358`	`358`	`this._expired.delete(client)`
`359`		`- this._remove(client, this._pulseQueue.bind(this))`
`360`		`- return`
	`359`	`+ return this._remove(client, this._pulseQueue.bind(this))`
`361`	`360`	`}`
`362`	`361`
`363`	`362`	`// idle timeout`
`364`	`363`	`let tid`
`365`	`364`	`if (this.options.idleTimeoutMillis) {`
`366`	`365`	`tid = setTimeout(() => {`
`367`	`366`	`this.log('remove idle client')`
`368`		`- this._remove(client)`
	`367`	`+ this._remove(client,this._pulseQueue.bind(this))`
`369`	`368`	`}, this.options.idleTimeoutMillis)`
`370`	`369`
`371`	`370`	`if (this.options.allowExitOnIdle) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ describe('idle timeout', () => {`
`50`	`50`	`try {`
`51`	`51`	`yield Promise.race([removal, timeout])`
`52`	`52`	`} finally {`
`53`		`- pool.end()`
	`53`	`+ yieldpool.end()`
`54`	`54`	`}`
`55`	`55`	`})`
`56`	`56`	`)`

Comments

(0)